Opened 10 years ago

Closed 9 years ago

#7916 closed patch (Won't Fix)

Automatically save cutlist during editing

Reported by: Jim Stichnoth <stichnot@…> Owned by: Janne Grunau
Priority: minor Milestone: unknown
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

All too frequently, my frontend hangs while editing a cutlist and all my edits are lost. (This can be easily tested by killing the mythfrontend process while editing and then trying to resume editing.) This patch saves all editing changes as they are made.

Attachments (3)

save_cutlist_incrementally.patch (2.8 KB) - added by Jim Stichnoth <stichnot@…> 10 years ago.
save_cutlist_incrementally_v2.patch (2.8 KB) - added by Jim Stichnoth <stichnot@…> 9 years ago.
save_cutlist_incrementally_v3.patch (4.1 KB) - added by Jim Stichnoth <stichnot@…> 9 years ago.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by Jim Stichnoth <stichnot@…>

comment:1 Changed 10 years ago by Stuart Auchterlonie

Milestone: unknown0.23

comment:2 Changed 10 years ago by paulh

Milestone: 0.230.24

Changed 9 years ago by Jim Stichnoth <stichnot@…>

comment:3 Changed 9 years ago by Jim Stichnoth <stichnot@…>

Updated with save_cutlist_incrementally_v2.patch after ProgramInfo? refactoring.

comment:4 Changed 9 years ago by Janne Grunau

Owner: changed from Isaac Richards to Janne Grunau
Status: newassigned
Version: unknownTrunk Head

Changed 9 years ago by Jim Stichnoth <stichnot@…>

comment:5 Changed 9 years ago by Jim Stichnoth <stichnot@…>

Updated with save_cutlist_incrementally_v3.patch after libmythui-osd branch merge.

comment:6 Changed 9 years ago by sphery

(In [26111]) Refactor the user interface of the recording cut list editor to take advantage of the new cleaner design of the editor provided by Mark's libmythui-osd code, which ensures users can't create invalid cut lists with discontinuities. Refs #7916. Fixes #8564. Fixes #8832.

Includes some changes to key bindings to make key usage more consistent with the rest of MythTV.

 * MENU no longer exits the editor.  It now brings up the menu.
 * SELECT no longer brings up the menu.  It now adds a new cut or, when in a cut area, prompts whether to move the cut start/end or delete the cut.
 * EDIT exits the editor and saves the cut list.
 * ESCAPE prompts whether to save the cut list or cancel changes, then exits.
 * DELETE can be used to delete a cut, when inside a cut area.
 * SAVEMAP (new binding, no default) saves the cut list without exiting (works well when mapped to the same key as TV Editing/TOGGLERECORD).

The menu allows moving the previous/next cut point to the current position or, if there is no previous/next cut point, cutting to the beginning or end of the recording, and allows adding a new cut. It also includes an option, "Cut List Options", which brings up a secondary menu allowing the user to "Clear Cut List", "Invert Cut List", "Undo Changes" (revert to the saved cut list), "Exit Without Saving", "Save Cut List" (without exiting), or "Save Cut List and Exit".

A typical editing session would involve:

 * Hit EDIT (E) to enter edit mode
 * Optionally import the flag list with LOADCOMMSKIP (Z)
 * Find the start (or end) frame for a new cut and press SELECT (Space/Enter)
 * Find the end (or start) frame for that cut and press SELECT (Space/Enter)
 * To adjust positions of existing cuts, find the desired frame, then press MENU (M), then select "Move Previous Cut End Here" or "Move Next Cut Start Here"
 * To remove a cut, press DELETE (D) inside the cut region
 * Hit EDIT (E) to exit edit mode and save the cut list

All actions could instead be performed with the MENU (M).

Thanks to Jim Stichnoth for the MythUIEditBar fixes and for the patches on #8564 that people have been using while I've been working on this patch.

comment:7 Changed 9 years ago by stuartm

Milestone: 0.24unknown

Michael, can this be closed now?

comment:8 Changed 9 years ago by sphery

Resolution: Won't Fix
Status: assignedclosed

Closing this ticket as Won't Fix for now. While the idea of auto-saving has merit, the patches here will no longer work after [26111], and the approach for a final implementation will likely need to change. Feel free to reopen with a new patch, once reworked.

Note: See TracTickets for help on using tickets.