Opened 10 years ago

Closed 10 years ago

#8025 closed patch (fixed)

JAMU always attempts to download banner art for 'movie' files when run with the -MW switch

Reported by: david.madsen@… Owned by: sphery
Priority: minor Milestone: unknown
Component: Contributed Scripts & Apps Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

After updating my metadata and fanart with the -MW swich I noticed that there were a few recorded movies in the list that always seemed to attempt to download banner art even though there is none available.

No matter how many times the script ran, those movies always queried the server looking for banner art. I poked around and tracked the issue back to here:

            # Search for graphics that are already downloaded
            for directory in graphicsDirectories.keys():
                if directory == 'screenshot':    # There is no downloading of screenshots required
                    program[directory] = True
                    continue
                if directory == 'banner' and program['subtitle'] == '': # No banners for movies
                    program[directory] = True
                    continue
                elif mirodetails:
                    if not mirodetails[u'tv'] and directory == 'banner': # No banners for movies
                        program[directory] = True
                        continue

The subtitle check for the banner directory never matched and forced the script to always attempt to update banner art. Changing the comparison to the following fixed the repetitive update issue for me. Movies that had fanart, and coverart no longer attempted to download images.

                if directory == 'banner' and program['subtitle'] == None: # No banners for movies

I have attached a simple patch for this change.

Attachments (1)

jamu_movie_subtitle.patch (603 bytes) - added by david.madsen@… 10 years ago.
Simple fix for subtitle check to detect movies

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by david.madsen@…

Attachment: jamu_movie_subtitle.patch added

Simple fix for subtitle check to detect movies

comment:1 Changed 10 years ago by robertm

Resolution: fixed
Status: newclosed

fixed in r23470.

Note: See TracTickets for help on using tickets.