Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8036 closed patch (fixed)

MTD: Error getting volume name, setting to "Unknown"

Reported by: jason.chambers@… Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: 0.22-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When importing a DVD using MTD (Myth Transcoding Daemon) on 0.22-fixes, the "Name" field is no longer populated with the DVD Volume name like it used to on 0.21.

The "Name" field just contains "Unknown" (or "Unknown - Title ...") and the mtd.log file contains the message:

Error getting volume name, setting to "Unknown"

This occurs because UDFGetDescriptor() returns with a false value in mythtv/libs/libmythdvdnav/dvdread/dvd_udf.c at line 888:

if(bufsize < DVD_VIDEO_LB_LEN)

return 0;

The value passed for the bufsize argument appears to be wrong - its passing sizeof(pointer) rather than sizeof(array).

This was fixed previously in changeset [9818] (back in 2006), but looks like it was undone in the re-sync with libdvdnav in changeset [19956]

Attached is a patch to restore the previous bufsize calculation assuming its still valid for the current code. It works on my 0.22-fixes frontends without any problems so far, but my C is very rusty so I don't know if its correct.

Attachments (1)

MTD_Error_getting_volume_name.diff (578 bytes) - added by jason.chambers@… 9 years ago.
Patch for 0.22-fixes

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by jason.chambers@…

Patch for 0.22-fixes

comment:1 Changed 9 years ago by robertm

Resolution: fixed
Status: newclosed

(In [23498]) Fix #8036. Restore a local change to dvd read library lost in the resync to allow DVD rip to get correct DVD label. Thanks to sharp-eyed user Jason Chambers for spotting this.

comment:2 Changed 9 years ago by nick@…

could this also be applied to 0.22-fixes?

Note: See TracTickets for help on using tickets.