Opened 15 years ago

Closed 15 years ago

#806 closed patch (fixed)

short circuit if passed fd is invalid in RingBuffer::safe_read()

Reported by: jwestfall@… Owned by: danielk
Priority: trivial Milestone: 0.19
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no


patch adds a short circuit to RingBuffer::safe_read(int, void*, uint) when the passed fd is invalid. No point in wasting time trying to read() from the fd multiple times. I run into this when firewire creates 0 byte files from not being able to pull data from the STB.

Attachments (1)

ringfd.diff (399 bytes) - added by anonymous 15 years ago.

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by anonymous

Attachment: ringfd.diff added

comment:1 Changed 15 years ago by danielk

Milestone: 0.19
Owner: changed from Isaac Richards to danielk

comment:2 Changed 15 years ago by danielk

Resolution: fixed
Status: newclosed

(In [8295]) Closes #806, by applying patch.

This just speeds up error recovery a tiny bit, and prints out a slightly more informative message, when a recorder fails to put any data into a file was supposed to record into.

Note: See TracTickets for help on using tickets.