Opened 10 years ago

Closed 8 years ago

#8075 closed Patch - Feature (Won't Fix)

Patch to allow switching between all and only favorite channels in mythweb listings

Reported by: Tom Dexter <digitalaudiorock@…> Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: yes

Description

If there's any interest, I'm attaching a patch that adds a link to the listings that allows you to switch between showing only favorite channels and all channels. It retains the current time slot and saves the change in the session.

I put the link in the same table with the jump-to time/date which seems like a pretty good place. This adds two new translation strings. I simply used 'Favorite channels' and 'ALL channels' for the text...not sure if that's what would be desirable or not. In my case I was trying to keep them fairly short to save page space.

Attachments (3)

listings_switch_favs.patch (2.0 KB) - added by Tom Dexter <digitalaudiorock@…> 10 years ago.
listings_switch_favs_englishonly.patch (2.0 KB) - added by Tom Dexter <digitalaudiorock@…> 10 years ago.
mythweb_guide_channelgroups.diff (12.3 KB) - added by anonymous 9 years ago.
(Uploading Tom's patch as anonymous to test Trac fix - mdean)

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by Tom Dexter <digitalaudiorock@…>

Attachment: listings_switch_favs.patch added

Changed 10 years ago by Tom Dexter <digitalaudiorock@…>

comment:1 Changed 10 years ago by Tom Dexter <digitalaudiorock@…>

For anyone that might want to use this without having to run mythweb/modules/_shared/lang/build_translation.pl I've attached an English only version that doesn't attempt to translate the new strings.

comment:2 Changed 10 years ago by sphery

Tom, any interest in extending the patch to allow users to select any of their defined channel groups rather than just all or favorites only?

Refs #7536.

comment:3 Changed 9 years ago by Tom Dexter <digitalaudiorock@…>

Sure...I'll look into that when I get some time. I'm a bit swamped at the moment. The only thing I'm unclear on however is this:

Right now there's simply a session variable indicating whether or not to show only favorites. In the patch I did, I'm simply changing that (just as if you did so in the settings). If this is changed to a dropdown list of the channel groups, would it be best to simply do the same in the settings? That is, to totally replace the "Only display favourite channels" checkbox in the settings to a dropdown for "channel group to display", with a default of none (for all)?

Sounds like a good feature in any case.

comment:4 Changed 9 years ago by Tom Dexter <digitalaudiorock@…>

Once I got thinking about this more it occurred to me: If there's a channel group dropdown list in the listings page and your choice gets remembered in the session, does it even make sense to have that duplicated in the Settings page? To me it's make more sense to just remove the old "Only display favourite channels" checkbox in the settings. That would be much like that "Show recordings:" dropdown list inthe recorded programs page. What do you think?

One area I'd have to look into that I'm not familiar with is how this might impact the other templates, especially the iPod one.

Changed 9 years ago by anonymous

(Uploading Tom's patch as anonymous to test Trac fix - mdean)

comment:5 Changed 9 years ago by anonymous

I'm really hoping this patch will be committed, it increases the level of usability quite a bit.

comment:6 Changed 9 years ago by robertm

Ticket locked: set

comment:7 Changed 9 years ago by robertm

Status: newassigned

comment:8 Changed 9 years ago by Rob Smith

Milestone: unknown0.25

comment:9 Changed 9 years ago by stuartm

Milestone: 0.25

Milestone 0.25 deleted

comment:10 Changed 9 years ago by Rob Smith

Milestone: 0.25unknown
Version: unknownTrunk Head

We're planning a full rewrite of the main mythweb template. This is going to be postponed until after that is complete.

comment:11 Changed 8 years ago by stuartm

Resolution: Won't Fix
Status: assignedclosed
Type: enhancementPatch - Feature
Note: See TracTickets for help on using tickets.