Opened 10 years ago

Closed 10 years ago

#8139 closed defect (fixed)

[PATCH] mythbrowser: fix for crash when doing "next link"

Reported by: Alec Leamas <leamas.alec@…> Owned by: paulh
Priority: minor Milestone: 0.23
Component: Plugin - MythBrowser Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When using mythbrowser from through the remote, the button bound to 'Z* causes myhtbrowser to stop working. See bug 8128 for more.

The problem can also be triggered from the keyboard using the the 'NEXT' key.

After some interesting work I have found that the crashes occurs iff the MythUIWebBrowser::keyPressEvent method returns false. The attached patch tries to fix this with as small changes as possible. I have not completely understood why the crashes occur, but to my understanding the patch does reasonable things, and the crashes seems to be gone.

The patch is generated n fedora. To apply:

cd mythtv-**/mythtv
patch -p2 <  wherever/patch1

Attachments (1)

patch1 (3.2 KB) - added by Alec Leamas <leamas.alec@…> 10 years ago.

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Alec Leamas <leamas.alec@…>

Attachment: patch1 added

comment:1 Changed 10 years ago by paulh

Milestone: unknown0.23
Status: newaccepted
Version: unknownhead

comment:2 Changed 10 years ago by paulh

Resolution: fixed
Status: acceptedclosed

(In [23731]) Re-work the keypress handling in MythUIWebBrowser.

This fixes the TOGGLEINPUT key-binding not working properly so you can now enter text properly on web pages. Also fixes the NEXTLINK, PREVIOUSLINK and FOLLOWLINK key-bindings not working when using a remote with myths lirc support. Fixes #7363, #8139.

Note: See TracTickets for help on using tickets.