Opened 10 years ago

Closed 9 years ago

#8149 closed patch (fixed)

Patch to fix install of Perl bindings

Reported by: Andres Mejia <mcitadel@…> Owned by: beirdo
Priority: minor Milestone: unknown
Component: Bindings - Perl Version: head
Severity: medium Keywords: perl vendor directories installdirs prefix
Cc: Ticket locked: no

Description

Here's a patch that fixes the installation of the Perl bindings. The current 'contains(PREFIX, ^/usr(/local)?/?$)' check will cause the Perl bindings to be installed to '/usr/local' even if the prefix is set to '/usr'. This patch will set PREFIX always.

Also, the Perl bindings should be installed to the Perl vendor directories instead of the default, which are the site directories. The site directories are tied to a particular release of Perl.

Attachments (2)

09_perl_bindings_prefix (1.1 KB) - added by Andres Mejia <mcitadel@…> 10 years ago.
Patch to fix installation of Perl bindings
09_perl_bindings_prefix.2 (2.4 KB) - added by Andres Mejia <mcitadel@…> 10 years ago.
Perl bindings installation fix

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Andres Mejia <mcitadel@…>

Attachment: 09_perl_bindings_prefix added

Patch to fix installation of Perl bindings

comment:1 Changed 10 years ago by xris

Vendor directories are for vendor-provided packages, site directories are for site-specific (i.e. self-compiled) installations. It's up to packagers to fix the directory locations for installs so files go into the vendor directory.

The rest of the patch looks fine.

comment:2 Changed 10 years ago by Andres Mejia <mcitadel@…>

So would a configure switch to set INSTALLDIRS be ok?

Changed 10 years ago by Andres Mejia <mcitadel@…>

Attachment: 09_perl_bindings_prefix.2 added

Perl bindings installation fix

comment:3 Changed 10 years ago by Andres Mejia <mcitadel@…>

Ok. I've attached another patch now that would make setting INSTALLDIRS optional (via a configure switch). It essentially allows for passing any kind of options to Perl when generating the Makefile.perl file.

comment:4 Changed 9 years ago by beirdo

Owner: changed from Rob Smith to beirdo
Status: newassigned

comment:5 Changed 9 years ago by beirdo

Resolution: fixed
Status: assignedclosed

(In [25450]) Uses PREFIX in the makefile for the perl bindings.

Thanks to Andres Mejia <mcitadel@…> Patch from #8149

Fixes #8149.

Note: See TracTickets for help on using tickets.