kDecoderProbeBufferSize increase causes LiveTV crash

[Nigel]

[23528] increased kDecoderProbeBufferSize from 64K to 1M. For some unknown reason, this is causing the MacOS X client to crash (HDHR, Live TV only):

(gdb) run -v playback
Starting program: /Volumes/Backups/MythTV/.osx-packager/src/myth-svn/mythtv/programs/mythfrontend/mythfrontend -v playback
...
2010-03-15 00:43:15.715 Using audio as timebase
2010-03-15 00:43:15.715 Video timing method: USleep with busy wait
2010-03-15 00:43:15.715 Refresh rate: 6666, frame interval: 40000
2010-03-15 00:43:15.716 NVP(0): LoadFilters(''..) -> 0x0
2010-03-15 00:43:15.719 RingBuf(/Volumes/Backups/Movies/1001_20100315004313.mpg): OpenFile(/Volumes/Backups/Movies/1001_20100315004314.mpg, 12)
2010-03-15 00:43:15.756 RingBuf(/Volumes/Backups/Movies/1001_20100315004314.mpg): CalcReadAheadThresh(0 KB)
			 -> threshhold(64 KB) min read(0 KB) blk size(32 KB)

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0xb0441ff0
[Switching to process 32381]
0x8fe11f32 in __dyld_misaligned_stack_error ()

or

Thread 11 Crashed:
0   dyld                          	0x8fe11f32 misaligned_stack_error + 0
1   ...havformat-0.23.0.23.0.dylib	0x00dad6cd get_buffer + 189 (aviobuf.c:316)

The file recorded by that LiveTV session (all 5 to 10 seconds of it) plays back just file in watch recordings.

[stridger@…]

I can confirm this on OSX 10.6.3 when compiling with osx-packager.pl -m32.

The log can be found on

​http://svn.mythtv.org/trac/ticket/8342

but is probably not very helpful.

[stridger@…]

Sorry to nag, but given that this is a showstopper for LiveTV in 0.23 on OSX, and RC3 is out already, is there a chance that the fix will make it into 0.23 final?

Thanks.

[robertm]

Please read the ticket howto.

[Janne Grunau]

(In [24618]) NVP: decrease kDecoderProbeBufferSize to 128k

reverts [23528] partially after the evob probe was fixed. Hopefully fixes the Mac OS X stack overflow in Refs #8179. Refs #7233

[Psychosis <psychos@…>]

Backported to 0.23-fixes, I can confirm this fixes LiveTV on 10.5/10.6 OS X (Intel).

[Nigel]

(In [25295]) Prevent stack overflow with LiveTV on Mac OS X, by allocating buffer from heap. Thanks to Christoph Rudorff. Refs #6211. Refs #8179. Tidier solution than trunk's [24618]?

[robertm]

Believe this should have been closed a bit ago.