Modify

Opened 8 years ago

Closed 5 years ago

#8217 closed Patch - Bug Fix (Fixed)

programs from xmltv source around DST change are off by 2h

Reported by: Andreas Oeldenberger <Andreas.Oeldenberger@…> Owned by: mdean
Priority: minor Milestone: 0.27
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords: DST UTC XMLTV QT
Cc: Ticket locked: no

Description

fromXMLTVDate is using QtDateTime::addSecs to calculate UTC time in Auto mode. Now if addSecs hits a DST change it will honor that an mess up our calculation.

To stop addSecs from doing this the TimeSpec? has to be set to Qt::UTC.

See attached path for a quick fix.

PS: Perhaps its time do drop MythUTCToLocal and use correct TimeSpecs? and QtDateTime::toLocalTime?

Attachments (1)

addSecsDST.patch (726 bytes) - added by Andreas Oeldenberger <Andreas.Oeldenberger@…> 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Andreas Oeldenberger <Andreas.Oeldenberger@…>

comment:1 Changed 8 years ago by mdean

  • Owner changed from stuartm to mdean
  • Status changed from new to accepted

comment:2 follow-up: Changed 6 years ago by stuartm

  • Type changed from patch to Patch - Bug Fix
  • Version changed from head to Master Head

Where does this fit with the switch to using GMT internally?

comment:3 in reply to: ↑ 2 Changed 6 years ago by Andreas Oeldenberger <andreas.oeldenberger@…>

Replying to stuartm:

Where does this fit with the switch to using GMT internally?

uhm.... wow!

Took a quick look at utc changes... should still be the same.

Note: I stopped using xmltv over a year ago. 2nd Note: You may only experience the bug for programs starting/stopping during the hour of DST Change as that's where QtDateTime::addSecs is doing it's magic.

comment:4 Changed 5 years ago by dekarl

  • Milestone changed from unknown to 0.27
  • Resolution set to Fixed
  • Status changed from accepted to closed

Should be fixed in [ff5ab27842c522f9e054876a8eb69a51b8c86a2e] in master by removing the code in question.

Add Comment

Modify Ticket

Action
as closed The owner will remain mdean.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.