Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8431 closed patch (fixed)

Remove Mac OS fullscreen hack

Reported by: sphery Owned by: Nigel
Priority: minor Milestone: 0.24
Component: Ports - OSX Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In #8121, Jeff Lu submitted a patch that fixes fullscreen mode on Windows, where the call to setWindowState(Qt::WindowFullScreen?) must come after the call to setWindowFlags(flags) . Before this patch, there was a hack added to workaround fullscreen not working properly on Mac OS by changing the window to be a Qt::SplashScreen? . It seems that the Mac OS hack was working around the same issue that Jeff saw on Windows, so we should be able to remove the splash screen hack, now, after [24479].

Attachments (1)

mythtv-remove_MacOS_splash_screen_hack.patch (647 bytes) - added by sphery 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by sphery

comment:1 Changed 9 years ago by sphery

Note that I haven't tested this change as I don't have Mac OS, but a couple of very kind users did so, as reported at http://www.gossamer-threads.com/lists/mythtv/dev/435271#435271 .

comment:2 Changed 9 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [24711]) Remove old Mac OS X fullscreen hack. Closes #8431. Also disables menubar hiding/enforcing, which seems to be done by Qt now?

comment:3 Changed 9 years ago by stuartm

Milestone: unknown0.24
Note: See TracTickets for help on using tickets.