Opened 10 years ago

Closed 9 years ago

#8449 closed enhancement (wontfix)

job list for mtd

Reported by: markeyb@… Owned by: Anduin Withers
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: Master Head
Severity: medium Keywords: mtd job list
Cc: Ticket locked: no

Description

This stores mtd jobs in a mysql table and if mtd fails for any reason it restarts currently fully ripped jobs the next time mtd is restart.

I was transcoding allot of files and when mtd failed I had to re-import the files off disk. It does not fix any issues with the underlying modules, it simply helps mitigate them.

Attachments (1)

final.diff (26.2 KB) - added by markeyb@… 10 years ago.
code for patch

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by markeyb@…

Attachment: final.diff added

code for patch

comment:1 Changed 10 years ago by robertm

Status: newinfoneeded_new

markeyb,

There is a *lot* going on in this patch that has nothing to do with the patch itself-- line wrapping, random conversational commenting, datestamping it with your name, etc. In order to be able to review this, I need to see the functional changes, doxygen commenting of any functions you add (see videodlg.cpp for examples of how to properly doxygen comment), and none of the extra formatting changes. For this to have any hope of being applied, it really needs to be easier to review.

Please revise with the following guidelines:

  • No whitespace-only changes.
  • No linewrapping-only changes.
  • No datestamping with your name.
  • No comments added to code that you are not touching.
  • No commenting out existing code. If it's not usable, remove it, don't comment it out.
  • Add doxygen commenting, not ad-hoc commenting
  • Spellcheck comments! They need to be in grammatically correct english.
  • No first-person commentary.
  • Update dbcheck code to match current schema, this version will not apply.
  • Initialize variables efficiently (int Track, Audio, Quality, AC3;)
  • Yikes, you can't just append to the log forever. Please remove that.

comment:2 Changed 9 years ago by robertm

Resolution: wontfix
Status: infoneeded_newclosed

No response, please feel free to reopen when above conditions are met.

Note: See TracTickets for help on using tickets.