Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8460 closed defect (fixed)

Jump when deleting recording rule

Reported by: jan@… Owned by: stuartm
Priority: minor Milestone: 0.24
Component: MythTV - General Version: 0.23-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When deleting a rule from the rule management screen, the cursor is jumping back to the first rule. This makes deleting serveral rules more work than necessary.

Attachments (1)

recpriority.patch (510 bytes) - added by Marc Alban <marcalban@…> 9 years ago.
Patch to fix jumping to the top of the list when deleting a recording rule.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by stuartm

Milestone: unknown0.24
Owner: changed from Isaac Richards to stuartm
Status: newaccepted

Changed 9 years ago by Marc Alban <marcalban@…>

Attachment: recpriority.patch added

Patch to fix jumping to the top of the list when deleting a recording rule.

comment:2 Changed 9 years ago by stuartm

Marc thanks for the patch, although it's not the preferred solution. I'll commit a better fix soon.

This code needs some serious cleanup as we are triggering multiple list rebuilds when a rule is deleted. Plus we're living in some alternate reality where reschedules apparently take a couple of ms, that's the only reason I can explain calling CountMatches?() immediately after deleting a rule. This screen should be monitoring scheduling events instead and generally should be more intelligent about when to make minimal updates vs expensive re-sorts, list rebuilds etc. I should have done all this when it was ported to mythui but I just didn't have the time to refactor/optimise every single screen.

comment:3 Changed 9 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [25764]) Fix the position being lost in the Recording Rules screen when a rule is deleted. Fixes #8460

comment:4 Changed 9 years ago by stuartm

Many of the issues I noted when taking a look at this issue are still outstanding, but I'll deal with those when I have more free time.

Note: See TracTickets for help on using tickets.