Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8477 closed defect (fixed)

Patchset #22999 break UPNP playback of file greater then 4G on 32 bits

Reported by: anonymous Owned by: danielk
Priority: minor Milestone: 0.24
Component: MythTV - UPnP Version: 0.23-fixes
Severity: medium Keywords: UPNP 32
Cc: Ticket locked: yes

Description

Declaration of the variable nFileSize on line 255 of the file upnpcdstv.cpp was changed from type "long long" to "size_t".

On 32 bits system, size_t cannot hold file size greater then 4G breaking the video playback of most HD recording.

Change History (9)

comment:1 Changed 8 years ago by robertm

Owner: changed from dblain to danielk
Status: newassigned

Daniel, reassigning to you since this was part of the programinfo refactor and david hasn't been around in a while.

comment:2 Changed 8 years ago by stuartm

Milestone: 0.23-fixesunknown
Priority: majorminor

comment:3 Changed 8 years ago by anonymous

I had many problems playing recordings on my PS3 through UPnP. I can confirm that compiling the trunk code with the proposed modification in the bug description (changing the nFileSize variable type from “size_t” to “long long”) fixes my bug. I’m running mythbackend with a hauppauge hd-pvr on a old P4 2.0ghz.

comment:4 Changed 8 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [24788]) Fixes #8477. size_t is too small on some platforms to hold a filesize. off_t should work on any UNIX99 compatible system, but I went with uint64_t since it will always be sufficiently large and we're not using this in any posix calls.

comment:5 Changed 8 years ago by superm1@…

Could this by chance be backported to 0.23-fixes too?

comment:6 in reply to:  5 Changed 8 years ago by anonymous

Replying to superm1@…:

Could this by chance be backported to 0.23-fixes too?

I definitively need this to upgrade my system to the 0.23 version. Please include this in the 0.23-fixes (it is due in 9 days!!).

comment:7 Changed 8 years ago by anonymous

Resolution: fixed
Status: closednew

Please include in 0.23-fixes

comment:8 Changed 8 years ago by robertm

Resolution: fixed
Status: newclosed
Ticket locked: set

Reopening closed tickets is not how to get them included.

comment:9 Changed 8 years ago by stuartm

Milestone: unknown0.24
Note: See TracTickets for help on using tickets.