Opened 14 years ago

Closed 14 years ago

#848 closed patch (fixed)

make mythweb listings also mark "oldrecorded" recordings

Reported by: Robert Tsai <rtsai1111> Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The mythweb TV listings grid only seems to mark recorded shows of things that have recording schedules; old "find-once" recordings (for example) don't get boxed as having already been recorded in the past.

This patch also joins the program table to the oldrecorded table to look for already-recorded things.

This is helpful to remember whether or not some movie or one-time program has been recorded in the past already.

Attachments (2)

mythweb.oldrecorded.diff (3.3 KB) - added by Robert Tsai <rtsai1111> 14 years ago.
mythweb.oldrecorded.2.diff (5.2 KB) - added by rtsai1111 14 years ago.
update patch to svn head, incorporate suggestions, make configurable

Download all attachments as: .zip

Change History (8)

Changed 14 years ago by Robert Tsai <rtsai1111>

Attachment: mythweb.oldrecorded.diff added

comment:1 Changed 14 years ago by Robert Tsai <rtsai1111>

Severity: mediumlow

comment:2 Changed 14 years ago by xris

is this one or #840 the newer one? Please close the duplicate.

Also, I'll consider this patch against *current* recordings stored on the hard drive, but not oldrecorded -- some of that data could be years old.

comment:3 Changed 14 years ago by Robert Tsai <rtsai1111>

I don't have years' worth of data in oldrecorded yet, and I have a fast backend machine, so I want to see everything.

Are you concerned about very very old "oldrecorded" data, or about the extra SQL JOIN?

If the former, how about if I modify the patch to accept a config option (statically defined in config.php) for a maximum age of "oldrecorded" data to consider for markup in the listings, with some reasonable default value (one year?)?

If the latter, then how about a separate option to configure whether or not to perform this JOIN at all (default to "off", to preserve current behavior)?

comment:4 Changed 14 years ago by xris

I just don't want oldrecorded stuff mucking up the listings page. However, if you wanted to create another border style for it that looks different than the "previously recorded" stuff generated by the scheduler, I'd be cool with that. Maybe a single pixel dash instead of the two-pixel one? Just something so it looks different.

comment:5 Changed 14 years ago by xris

(In [8461]) add a style as I suggested in/re #848

Changed 14 years ago by rtsai1111

Attachment: mythweb.oldrecorded.2.diff added

update patch to svn head, incorporate suggestions, make configurable

comment:6 Changed 14 years ago by xris

Resolution: fixed
Status: newclosed

(In [8613]) apply parts of patch to close #848.. didn't need the configuration, just wanted the different css for it. Also updated some recstatus strings for english

Note: See TracTickets for help on using tickets.