Opened 14 years ago
Closed 14 years ago
#8491 closed defect (fixed)
Commercial detection runs for commercial-free channels
Reported by: | sphery | Owned by: | jpoet |
---|---|---|---|
Priority: | minor | Milestone: | 0.24 |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Since the ProgramInfo? refactor, it seems that we only set FL_CHANCOMMFREE in the programflags when reading a RecordingInfo? from the DB. So, when init_jobs() ( libs/libmythtv/tv_rec.cpp around line 3901) looks at rec->IsCommercialFree?(), it always gets false (because the RI was created from a PI, not read from the DB).
From discussion on IRC: "The first thing I'd do is check if we can just load those flags in the jobqueue's PI. Alternatively we can pull it from the DB with a QueryIsCommercialFree?() call."
(Leaving this at MythTV-General since it's more related to ProgramInfo? than to mythcommflag.)
Attachments (2)
Change History (7)
comment:1 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|---|
Owner: | changed from Isaac Richards to danielk |
Status: | new → accepted |
Changed 14 years ago by
Attachment: | 8491-v1.patch added |
---|
comment:2 Changed 14 years ago by
sphery, this is completely untested, but in theory should fix the problem.
Changed 14 years ago by
Attachment: | 8491-scheduler-fixed.patch added |
---|
comment:3 Changed 14 years ago by
There's a small error in scheduler.cpp part of the patch related to comma usage in SQL. I've attached patch to (only) scheduler.cpp which have these problems corrected.
With the original patch and these modifications, commfree functionality works again and I haven't seen any ill effects with limited testing. There are some other issues with commflagging but those should go to separate ticket.
comment:4 Changed 14 years ago by
Owner: | changed from danielk to jpoet |
---|---|
Status: | accepted → assigned |
Possible fix