Opened 9 years ago

Closed 9 years ago

#8491 closed defect (fixed)

Commercial detection runs for commercial-free channels

Reported by: sphery Owned by: jpoet
Priority: minor Milestone: 0.24
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Since the ProgramInfo? refactor, it seems that we only set FL_CHANCOMMFREE in the programflags when reading a RecordingInfo? from the DB. So, when init_jobs() ( libs/libmythtv/tv_rec.cpp around line 3901) looks at rec->IsCommercialFree?(), it always gets false (because the RI was created from a PI, not read from the DB).

From discussion on IRC: "The first thing I'd do is check if we can just load those flags in the jobqueue's PI. Alternatively we can pull it from the DB with a QueryIsCommercialFree?() call."

(Leaving this at MythTV-General since it's more related to ProgramInfo? than to mythcommflag.)

Attachments (2)

8491-v1.patch (4.8 KB) - added by danielk 9 years ago.
Possible fix
8491-scheduler-fixed.patch (2.3 KB) - added by otto at kolsi dot fi 9 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by danielk

Milestone: unknown0.24
Owner: changed from Isaac Richards to danielk
Status: newaccepted

Changed 9 years ago by danielk

Attachment: 8491-v1.patch added

Possible fix

comment:2 Changed 9 years ago by danielk

sphery, this is completely untested, but in theory should fix the problem.

Changed 9 years ago by otto at kolsi dot fi

Attachment: 8491-scheduler-fixed.patch added

comment:3 Changed 9 years ago by otto at kolsi dot fi

There's a small error in scheduler.cpp part of the patch related to comma usage in SQL. I've attached patch to (only) scheduler.cpp which have these problems corrected.

With the original patch and these modifications, commfree functionality works again and I haven't seen any ill effects with limited testing. There are some other issues with commflagging but those should go to separate ticket.

comment:4 Changed 9 years ago by sphery

Owner: changed from danielk to jpoet
Status: acceptedassigned

comment:5 Changed 9 years ago by jpoet

Resolution: fixed
Status: assignedclosed

(In [26147]) Don't flag commercials on channels marked as comm-free.

Patch by Daniel Kristjansson with syntax fixes by Otto Kolsi.

Fixes #8491

Note: See TracTickets for help on using tickets.