Opened 15 years ago

Closed 15 years ago

#851 closed defect (fixed)

NuppelVideoPlayer::FrameIsInMap always returns true if breakMap is not empty

Reported by: anonymous Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no


NuppelVideoPlayer::FrameIsInMap? always returns true if breakMap is not empty. The result is that the thumbnail preview images always are generated from near the end of the recording.

This patch works for me.

Index: libs/libmythtv/NuppelVideoPlayer.cpp
--- libs/libmythtv/NuppelVideoPlayer.cpp        (revision 8336)
+++ libs/libmythtv/NuppelVideoPlayer.cpp        (working copy)
@@ -3790,6 +3790,10 @@
                 ((lastType == MARK_COMM_START) ||
                  (lastType == MARK_CUT_START)))
                 return true;
+            if ((type == MARK_COMM_START) ||
+                 (type == MARK_CUT_START))
+                return false;
         lastType =;

Change History (1)

comment:1 Changed 15 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [8412]) Closes #851 by applying patch from anonymous. NVP::FrameIsInMap? wasn't short-circuiting and returning false once we realized the frame was not in a cut or commercial portion of the video. This may cure up the issue that some people have reported where the preview pixmap was coming from the end of the video always.

Note: See TracTickets for help on using tickets.