Opened 14 years ago
Closed 14 years ago
Last modified 14 years ago
#8530 closed patch (fixed)
Wrong encoding of phrases
Reported by: | Owned by: | sphery | |
---|---|---|---|
Priority: | minor | Milestone: | 0.23-fixes |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
In the Manage Recordings->Schedule Recordings->Search Words->Titles (an other options in this menu), the "Title/Phrase?" screen is using a wrong charset when displaying phrases. The phrases are stored UTF-8 encoded in the database backend, but the are displayed ISO-8859-1 or ASCII encoded in the frontend. This is similar to other ticket #7813 http://svn.mythtv.org/trac/ticket/7813. In the course of the discussion in this ticket http://svn.mythtv.org/trac/ticket/7813#comment:5 mdean wrote: "Qt-MySQL drivers use QVariant::ByteArray?? for string-type MySQL fields marked with the BINARY attribute (those using a *_bin collation) and QVariant::String for all others. Since QVariant::toString() uses QString::fromAscii() (through QVariant::convert()) when the QVariant's type is QVariant::ByteArray??, we have to use QString::fromUtf8() explicitly to prevent corrupting characters for any columns using a binary collation (or, at the minimum, in any location where the value retrieved from the database is shown to the user).
The following columns are binary (using utf8_bin collation), and may require similar treatment: keyword.phrase oldprogram.oldtitle people.name powerpriority.priorityname recgrouppassword.recgroup storagegroup.dirname "
Attached patch fixes bug with wrong encoding of phrases stored in keyword.phrase field.
Attachments (1)
Change History (6)
Changed 14 years ago by
Attachment: | phrase_encoding_in_proglist.patch added |
---|
comment:1 Changed 14 years ago by
Owner: | changed from Isaac Richards to sphery |
---|---|
Status: | new → assigned |
comment:2 Changed 14 years ago by
Status: | assigned → accepted |
---|
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
comment:5 Changed 14 years ago by
Milestone: | unknown → 0.23-fixes |
---|
(In [25424]) Fix the phrase encoding in proglist.cpp.
This is another case of improper conversion of utf8_bin column data, like the case in #7813. This fixes the issue until I can convert all the utf8_bin columns to utf8_general_ci.
Refs #8530. Thanks to sandybigboy for identifying the issue and submitting the patch.