Opened 14 years ago

Closed 14 years ago

#854 closed defect (fixed)

Channel Icons pointing to wrong location in mythweb

Reported by: skd5aner@… Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The channel icons in mythweb do not display because they are pointing to a directory that doesn't exist - mythweb/tv/images/icons/. Icons are actually stored in mythweb/images/icons/. I'm not sure if Chris meant to change where they are stored and didn't create the new location or if it should point to the original location where the icons are indeed still stored.

Change History (11)

comment:1 Changed 14 years ago by skd5aner-AT-gmail-DOT-com

Actually, I should add that left.gif and right.gif are also pointing to the tv sub-directory as well.

comment:2 Changed 14 years ago by anonymous

Version: head

comment:3 Changed 14 years ago by Robert Tsai <rtsai1111>

The patch in #837 addresses the channel icon problem. I think it also fixes left.gif and right.gif (I didn't notice any problems here, but I don't see anything wrong with my TV listings).

comment:4 Changed 14 years ago by xris

Resolution: fixed
Status: newclosed

(In [8341]) this should fix #854

comment:5 Changed 14 years ago by skd5aner@…

Not working for me. Now I don't see any icons (instead of just broken icons). Also, the left and right gifs still appear as broken.

I'm also seeing "/themes/Default/img/spacer.gif" applying wrong on several different pages.

comment:6 Changed 14 years ago by anonymous

Resolution: fixed
Status: closedreopened

comment:7 Changed 14 years ago by skd5aner@…

If I change line 107 in includes/channels.php from

$this->icon         = root."data/icons/".basename($channel_data['icon']);

to

$this->icon         = data/icons/".basename($channel_data['icon']);

...the icons will populate. However, I still get the mighty red-X when I try to view the listing. It says it's trying to point to "tv/data/icons/" rather than "data/icons/". I'm not exactly sure where that is set, but I'm sure you can find it pretty easily. HTH!

comment:8 Changed 14 years ago by torbjorn.jansson@…

Changeset [8341] does not fix the problem completly because the is_file() function uses local filesyste path and not virutal dir as seen by the webserver.

This is easily fixed by changing

if (is_file($channel->icon))

to

if (is_file($_SERVER["DOCUMENT_ROOT"]."/".$channel->icon))

in themes/default/tv/list.php themes/default/tv/detail.php and themes/default/tv/channel.php

comment:9 Changed 14 years ago by xris

Resolution: fixed
Status: reopenedclosed

(In [8431]) hopefully close #854 for good, using what I hope is a more robuyst check than the similar one proposed in the ticket

comment:10 Changed 14 years ago by torbjorn.jansson@…

Resolution: fixed
Status: closedreopened

Getting closer but not quite there yet ;)

This time if the icon field in the channels table is emty mythweb shows a thick white line where the icon should have been and the image link is http://hostname/MythWeb/data/tv_icons/ without any filename.

This happends on dvb channels mythbackend have auto added, all my other channels without any icons have the icon field set to the string "none" and they show up properly in mythweb wihtout any icon and without any whilte line.

comment:11 Changed 14 years ago by xris

Resolution: fixed
Status: reopenedclosed

(In [8457]) one more try to close #854

Note: See TracTickets for help on using tickets.