id,summary,reporter,owner,description,type,status,priority,milestone,component,version,severity,resolution,keywords,cc,mlocked 8547,Mythcommflag broken in trunk,km@…,danielk,"As late as today (revision 25063) mythcommflag has serious problems. The trivial one is from Changeset 24694 for trunk/mythtv/programs/mythcommflag/main.cpp. ---- @@ -868,5 +872,5 @@ QString outputfilename = QString::null; - QString chanid; + uint chanid; QString starttime; QString allStart = ""19700101000000""; ---- which makes chanid an uninitialized uint, which causes the test to fail in --- @@ -1285,6 +1290,6 @@ } - if ((chanid.isEmpty() && !starttime.isEmpty()) || - (!chanid.isEmpty() && starttime.isEmpty())) + if ((!chanid && !starttime.isEmpty()) || + (chanid && starttime.isEmpty())) { VERBOSE(VB_IMPORTANT, ""You must specify both the Channel ID "" --- As a result mythcommflag with no arguments will always fail with the message above and terminate. The more serious problem is a non-deterministic one. Even when mythcommflag is invoked with a file argument, it will often segfault in the middle of processing the file. If run repeatedly on the same file it segfaults at different frame numbers in each run. I'm attaching gdb output of successive runs. ",defect,closed,minor,0.24,MythTV - Mythcommflag,Master Head,low,fixed,,,0