Opened 9 years ago

Closed 9 years ago

#8646 closed defect (fixed)

tmdb.py not re-downloading corrupted images

Reported by: JYA Owned by: robertm
Priority: minor Milestone: unknown
Component: Plugin - MythVideo Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

An issue in the metadata (fixed in r25296) download, meant that some images (fanart and coverart) weren't downloaded properly. Yet a 0 bytes file for each image was created in the related storage group directory.

In mythvideo browser, the icon just appeared as black, and an error in the log showed that the file couldn't be opened. Attempting to re-download the metadata (doing info -> reset metadata, info -> retrieve) wouldn't re-download the images. You have to manually delete the 0 bytes file in the directory, and redownload the metadata, only then would the pictures be downloaded again.

Expected result: if the images are corrupted or can not be opened, they are marked as such, and retrieving video details again will attempt to redownload the images

Change History (3)

comment:1 Changed 9 years ago by JYA

Owner: changed from Anduin Withers to robertm
Status: newassigned

comment:2 Changed 9 years ago by JYA

Thinking about it more, maybe if the file hadn't been created in the first place following an error, there wouldn't have been an issue.

So maybe both conditions should be handled: -Not creating a file if an error occurred during download -Redownload when retrieving metadata if the already downloaded image is invalid

comment:3 Changed 9 years ago by robertm

Resolution: fixed
Status: assignedclosed

(In [25329]) Restore the old image validity check that I mistakenly removed a few days ago. Should fix #8646.

Note: See TracTickets for help on using tickets.