Opened 10 years ago

Closed 10 years ago

#8664 closed enhancement (Won't Fix)

Caption only mode

Reported by: Dave Badia <dbadia@…> Owned by: beirdo
Priority: minor Milestone: unknown
Component: Plugin - MythGallery Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no


Current behavior in MythGallery is such that if "Caption Overlay" mode is enabled, the image metadata is checked for a caption. If found it is displayed, otherwise the filename is displayed instead.

This patch makes the filename fallback configurable (as in it can be disabled) and presents a new option in the MythGallery config screen called "Use image file name as caption if no embedded data exists". The flag is set on by default in order to keep default behavior the same as previous releases.

Feedback/suggestions on wording,etc is welcome.

Attachments (1)

caption-fallback.dif (4.3 KB) - added by Dave Badia <dbadia@…> 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Dave Badia <dbadia@…>

Attachment: caption-fallback.dif added

comment:1 Changed 10 years ago by robertm

Personally, I would resist a configuration option for such a minor behavior. Why not just always use the filename as a caption if captions are enabled and no other caption exists? Myth has way too many options and this one is exactly the kind of thing we're trying to eliminate, not add.

comment:2 Changed 10 years ago by robertm

Actually, if I'm reading this properly, we already fall back to file name if no other caption exists. I am very opposed to adding a setting for this kind of thing. It's death by a thousand cuts-- Myth becomes more complicated to use every time we add a setting for something so minute.

comment:3 Changed 10 years ago by stuartm

The place to handle this sort of thing would probably be the theme, but until these parts of mythgallery are ported to mythui we can't even start to think about doing it that way.

There is a compromise, instead of another setting modify the existing setting to be a combobox with three (or more) possible configurations. 'No Captions', 'Captions Only', 'Caption or Filename'.

comment:4 Changed 10 years ago by Dave Badia <dbadia@…>

Realized I didn't mention the goal of the patch when I submitted it. During the slideshow I find it preferable to only see the caption if there was one intentionally embedded in the file, as IMHO seeing the filename in that particular view just blocks part of the image.

Anyway, I understand the desire to not add more config options. I like the suggestion of 'No Captions', 'Captions Only', 'Caption or Filename'. However the current caption option let’s the user choose the number of seconds for which to display the caption on the fullsize image. Interestingly enough, I did some testing of that setting and opened ticket:8675 as it doesn’t appear to be working as described.

So, I suppose we need to work through the defect to see what the desired logic really is around that setting. If deemed ok to drop the number of seconds option and just replace it with ‘Caption or Filename’, I’ll be glad to work on the 3 option suggestion.

comment:5 Changed 10 years ago by beirdo

Status: newassigned

comment:6 Changed 10 years ago by beirdo

I have attempted to incorporate this, using stuartm's suggestion. However, the usability of the icon view (aka directory tree) is gone when saying not to use filenames (if you have no captions, and directories never do). Unfortunately, the same caption is used to create the icon view as is used to overlay in the picture display.

I'm rejecting this at this point. Once we redo mythgallery to use mythui, I think that maybe we can revisit the idea of captions for the pictures as being separate from the directory view, and then this may make sense.

comment:7 Changed 10 years ago by beirdo

Resolution: Won't Fix
Status: assignedclosed
Note: See TracTickets for help on using tickets.