Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8669 closed defect (invalid)

Numeric input is cleared immediately during playback

Reported by: ijc@… Owned by:
Priority: minor Milestone: unknown
Component: MythTV - General Version: 0.23-fixes
Severity: medium Keywords:
Cc: danielk Ticket locked: no

Description

Qobject::startTimer and hence TV::StartTimer? take a timeout in milliseconds. This means that the queueInputTimer is set to expire after just 10ms which isn't really long enough to hit a second button before the queued input is cleared and therefore jump to and arbitrary seek type functionality doesn't work properly.

The attached patch changes the timeout to 10s which I suspect is what the author intended.

It would be nice to fix this in 0.23-fixes as well.

Attachments (2)

queueInputTimerFix.patch (3.2 KB) - added by ijc@… 10 years ago.
Increase queued input timeout to 10s
mythtv-remove_smart_channel_change_setting.patch (3.6 KB) - added by sphery 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by ijc@…

Attachment: queueInputTimerFix.patch added

Increase queued input timeout to 10s

comment:1 Changed 10 years ago by anonymous

FWIW I also don't see the queued input on the OSD but I've not had a chance to check if this is down to the theme or not yet.

comment:2 Changed 10 years ago by Ian Campbell <ijc@…>

I've just tested and the lack of OSD display seems to be theme specific. FWIW I was using Glass-OSD.

comment:3 Changed 10 years ago by sphery

Milestone: 0.24

The described behavior only occurs if:

Change channels immediately without select
When a complete channel number is entered MythTV will switch to that channel immediately without requiring you to hit the select button.

is enabled and only when the numeric input matches a channel number. I don't know if this is a bug or if it's the desired behavior (since it /is/ in fact changing channels immediately).

Changed 10 years ago by sphery

comment:4 Changed 10 years ago by sphery

Summary: Allow 10s rather than 10ms for queued input during playbackRemove "Change channels immediately without select" setting
Type: defectpatch

Attached patch, mythtv-remove_smart_channel_change_setting.patch , "fixes" the issue by removing the "Change channels immediately without select" setting.

IMHO, the "Change channels immediately without select" setting cannot be justified since a) enabling the setting means that other MythTV functionality (such as the arbitrary seek functionality) will not work properly with certain numeric input (any numeric input that matches a channel number--meaning users will see confusing results) and b) with the setting disabled, the channel is changed upon the input timeout, which seems to be about 3s (and is the behavior the reporter desires).

Unless someone provides a reasonable argument for keeping the setting, I plan to commit this change to trunk in the near future. Note that the setting is disabled by default, so likely the majority of users have it disabled and will see no difference in behavior after the setting is removed.

icj, please disable the "Change channels immediately without select" setting (in Utilities/Setup?|Setup|TV Settings|General , first screen) to get the behavior you want. Thanks for bringing this old setting to our attention.

comment:5 Changed 10 years ago by Ian Campbell <ijc@…>

The "Change channels immediately without select" setting is already disabled in my configuration ( doubled checked the DB and SmartChannelChange? == 0). Did you mean for me to enable it? (From what you say I don't think so).

Note that I see the issue with recorded rather than live TV (I haven't tried live), does "change channel" have any meaning in that context?

I have heavily instrumented tv_play.cpp and I am definitely seeing the queueInputTimerId timer firing pretty much immediately after I press any numeric button and causing the queuedInput to be wiped. 10ms for this timer can't be right, can it?

comment:6 Changed 10 years ago by sphery

Summary: Remove "Change channels immediately without select" settingNumeric input is cleared immediately during playback
Type: patchdefect

comment:7 Changed 10 years ago by sphery

Resolution: invalid
Status: newclosed

Reporter found that the problem was due to an out-of-date OSD theme, as described at http://mythtv.org/pipermail/mythtv-dev/2010-July/068928.html .

comment:8 Changed 10 years ago by marc@…

The Glass theme has been updated and now works correctly - http://castlesblog.com/2009/november/30/mythtv-glass-osd

Note: See TracTickets for help on using tickets.