Opened 9 years ago

Closed 9 years ago

#8686 closed patch (fixed)

Error reporting for invalid xml

Reported by: Nick King <penguin@…> Owned by: robertm
Priority: trivial Milestone: 0.24
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The current datadirect handler assumes that the XML data received from schedulesdirect is valid, and silently ignores when it fails to parse the file correctly. I have spent the past 4 days trying to determine why mythfilldatabase was failing to grab data. After examining the raw data from schedulesdirect, I discovered that the XML data was missing an opening tag (causing a tag mismatch, which causes the parser to exit). The attached patch causes an error line to be printed when the parser returns false (occurs when the parser encounters an unexpected EOF or invalid XML).

Attachments (1)

dd_report_parse_fail.patch (627 bytes) - added by Nick King <penguin@…> 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Nick King <penguin@…>

Attachment: dd_report_parse_fail.patch added

comment:1 Changed 9 years ago by robertm

Owner: changed from stuartm to robertm
Status: newassigned

comment:2 Changed 9 years ago by robertm

Milestone: unknown0.24

comment:3 Changed 9 years ago by robertm

Resolution: fixed
Status: assignedclosed

(In [25999]) If Schedules Direct XML downloaded fails to properly parse, output an error message and mark return as not ok. Could probably use a better error handler to indicate where the parse error is, but I don't have time to look at it right now. Fixes #8686.

Note: See TracTickets for help on using tickets.