Opened 9 years ago

Closed 9 years ago

#8708 closed patch (fixed)

Password urlencoding in MythWeb

Reported by: otto at kolsi dot fi Owned by: Rob Smith
Priority: minor Milestone: 0.24
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Http basic auth passwords which are now embedded in the external music streaming URLs ([25375]), require urlencoding so that passwords with special characters (at least '@') would work. Attached patch has a fix for this.

This fixes streaming with WinAmp?, but it seems that xmms still doesn't like passwords with encoded special chars. As discussed in IRC, MythWeb might still need a setting which tells whether to embed the auth info to URLs or not.

I've tested this patch with only music streaming, not videos.

Attachments (1)

mythweb-pswd-encode.patch (706 bytes) - added by otto at kolsi dot fi 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by otto at kolsi dot fi

Attachment: mythweb-pswd-encode.patch added

comment:1 Changed 9 years ago by robertm

Status: newassigned

comment:2 Changed 9 years ago by Rob Smith

Milestone: unknown0.24

comment:3 Changed 9 years ago by Rob Smith

Resolution: fixed
Status: assignedclosed

(In [26127]) Fixes #8708, this makes the http auth link creation an option defaulted off

Note: See TracTickets for help on using tickets.