Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8763 closed patch (fixed)

UPnP server does not work with Windows 7

Reported by: mattpyne@… Owned by: beirdo
Priority: minor Milestone: 0.24
Component: MythTV - UPnP Version: Master Head
Severity: medium Keywords: UPnP Windows Media Player
Cc: Ticket locked: no

Description

This patch adds code to detect the UPnP client and then uses that client identification to modify it's output to Windows Media Player 12 (Only on Windows 7).

This fixes the following:

  1. Recorded Programs are listed under RecordedTV in WMP12
  2. Entries are only list once (instead of 6 or more times)

Attachments (2)

upnp-wmp12.patch (17.9 KB) - added by mattpyne@… 9 years ago.
Patch for UPnP wmp12 support
0001-Reworked-patch-from-8763-WMP12-support.patch (27.5 KB) - added by beirdo 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by mattpyne@…

Attachment: upnp-wmp12.patch added

Patch for UPnP wmp12 support

comment:1 Changed 9 years ago by beirdo

Owner: changed from dblain to beirdo
Status: newassigned

comment:2 Changed 9 years ago by beirdo

Status: assignedaccepted

Thanks for the patch. I'm working through it now. However, in the future, please be SURE to not use tabs, but rather 4 spaces for indentation. I've cleaned this one up though.

Changed 9 years ago by beirdo

comment:3 Changed 9 years ago by beirdo

Status: acceptedinfoneeded

Please double-check the sections where you had removed the check for ContainerID 13 for WMP, I put that check back in, but I'd like confirmation on that before this is committed. I also redid the DetermineClient? section a bit into an easier to maintain chunk. I do not have WMP12 (or any other version) on the network, so I can not test this.

Please check my patch against trunk, and let me know if this still does what you need.

comment:4 Changed 9 years ago by mattpyne@…

Ok, point taken about the spaces. I though I'd got them all! Sorry for that!

I believe the ContainerID was being used to determine if it was actually a WMP client, as the previous code did not have any other way of identifying clients, that is why I removed it. However, I have checked your code against WMP12 and WMP11 and it works fine, so I am happy for it to be committed as you have it. I believe it is a bit belt & braces, but it doesn't matter so if you could commit it that would be very nice of you!

Thanks, Matt.

comment:5 Changed 9 years ago by beirdo

Resolution: fixed
Status: infoneededclosed

(In [25763]) Adds code to apply exceptions based on UPnP client types. In particular, WMP (old and new), and Xbox360 are dealt with a bit cleaner now.

Based on a patch from mattpyne@… Closes #8763

comment:6 Changed 9 years ago by stuartm

Milestone: unknown0.24
Note: See TracTickets for help on using tickets.