Opened 9 years ago

Closed 9 years ago

#8817 closed defect (fixed)

DVD play from the bookmark problem

Reported by: otto at kolsi dot fi Owned by: markk
Priority: minor Milestone: 0.24
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Playing DVD from the saved bookmark is not working correctly. Playback seems to start from the position which is too early. Saved bookmark data in DB looks valid, although I cannot say whether the saved framenum is correct or not (how this can be verified?).

mysql> select * from dvdbookmark where name like '%DISC4';
+----------+------------------+-------+----------+-------------+----------+---------------------+
| serialid | name             | title | audionum | subtitlenum | framenum | timestamp           |
+----------+------------------+-------+----------+-------------+----------+---------------------+
| 355A73DC | 24_SEASON5_DISC4 |     4 |        0 |           0 |     3734 | 2010-08-23 11:41:52 |
+----------+------------------+-------+----------+-------------+----------+---------------------+

Change History (7)

comment:1 Changed 9 years ago by robertm

Owner: changed from robertm to tralph
Status: newassigned

Assigning to tralph for the moment since it appears related to the recent timestamp change-- if it's still an issue after that bounce this back to me.

comment:2 Changed 9 years ago by robertm

Component: MythTV - Blu-ray PlaybackMythTV - DVD Playback
Owner: changed from tralph to markk

Reassigning... No idea who to give DVD tickets to now, I don't know much about it so I'm probably not the right person to fix it.

comment:3 Changed 9 years ago by otto at kolsi dot fi

Little bit info on this one. For example, if bookmark is saved at around 10 minutes, dvdbookmark table contains framenum ~15000 which sounds about right (25fps*60*10 = 15000).

However, when playback is started from this bookmark, it continues around time 0:53.

I added some printf debug statements and when playback starts from bookmark, correct framenum is queried from the DB. It gets all the way to the DoFastForward?() and to WaitForSeek?() where decoderSeek value is same as in DB.

Normally I have the exact seeking setting off, tried with that on but it didn't change the behaviour.

Furthermore, I noticed that saved bookmarks in the beginning (or with small framenum / seek) do seem to work. For example bookmark saved earlier than 1 minute seems to work correctly. Haven't tested what is the breaking point where bookmarks stop functioning.

comment:4 Changed 9 years ago by markk

Milestone: unknown0.24
Status: assignedaccepted

comment:5 Changed 9 years ago by markk

(In [26569]) Add some additional DVD bookmark debugging and remove some entirely redundant DVD code. Refs #8817.

(Note: DVD bookmark functionality was broken in r25858. MythIOWrapper doesn't seem to return the serial number or title of the disk.)

comment:6 Changed 9 years ago by markk

(In [26583]) Minor refactor of the position map resetting code which will help DVD playback. No functional changes. Refs #8817

comment:7 Changed 9 years ago by markk

Resolution: fixed
Status: acceptedclosed

(In [26584]) Fix DVD bookmark seeking. Closes #8817

Note: See TracTickets for help on using tickets.