Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8818 closed patch (fixed)

i18n themestring update for 0.24

Reported by: Kenni Lund [kenni AT kelu d0t dk] <kenni@…> Owned by: stuartm
Priority: minor Milestone: 0.24
Component: Translations Version: Master Head
Severity: medium Keywords: themestring update i18n
Cc: Ticket locked: no

Description

The themestring update in r25760 unfortunately added ~400 unwanted strings, by including strings from the plugins both in the themestrings.h files of the plugins (correct), as well as in the themestrings.h of mythfrontend (wrong). Search for "Humidity" or "ROM Name" in trunk/mythtv/themes/themestrings.h to confirm this.

The attached patch updates the themestringtool run script for current trunk/0.24. It should be sufficient to just run the script afterwards to generate the themestrings for mythfrontend and the plugins (hopefully without any errors).

The patch is mostly cosmetic changes to remove unwanted error messages and make it more user friendly:

  1. Add a short introduction in the beginning of the script, describing its purpose.
  2. Add a check to see if the themestringstool has been compiled before trying to do anything.
  3. Remove the weather.com maps.xml hack, since it has been entirely removed from mythweather in r25182.
  4. Remove (comment out) zoneminder-ui.xml as it didn't exist for 0.23, still doesn't exist in trunk and doesn't seem to be receiving any love at all.
  5. Remove (comment out) the call of emacs at the end of the script...not everyone is using emacs and/or has the tool installed :)

Attachments (3)

update_themestringstool_run_script.patch (2.2 KB) - added by Kenni Lund [kenni AT kelu d0t dk] <kenni@…> 8 years ago.
update_themestringstool_run_script_v2.patch (2.4 KB) - added by Kenni Lund [kenni AT kelu d0t dk] <kenni@…> 8 years ago.
Updated patch
themestrings.diff (38.5 KB) - added by Kenni Lund [kenni AT kelu d0t dk] <kenni@…> 8 years ago.
Themestrings diff

Download all attachments as: .zip

Change History (15)

Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

comment:1 Changed 8 years ago by robertm

Status: newinfoneeded_new

Hi Kenni,

Unfortunately, on my system, running this updated script changes nothing. Were you expecting translations to move?

comment:2 Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

Yes, 415 strings should get removed from trunk/mythtv/themes/themestrings.h...but this is not due to the my changes, this should be the same with the old run.sh script. The update just removes all the errors. I just do a clean checkout of trunk, cd themestringstool, qmake, make, ./run.sh.

comment:3 Changed 8 years ago by robertm

Sorry Kenni, it doesn't do the job. Unmodified trunk here gets no changes with or without your patched run.sh script.

comment:4 Changed 8 years ago by robertm

Status: infoneeded_newnew

comment:5 Changed 8 years ago by robertm

Owner: changed from Reynaldo H. Verdejo Pinochet to stuartm
Status: newassigned

comment:6 Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

Are you running the script with root privileges? That would ignore the "remove read permissions" logic of the script. I just tested it, running as a regular user gives me 703 strings, while root gives me 1115 strings. I'll update the patch with a root-user-check in a few minutes.

Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

Updated patch

comment:7 Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

New patch uploaded which checks the userid before proceeding.

comment:8 Changed 8 years ago by robertm

(In [25808]) Update run.sh tool in themestringtool to be compatible with trunk. Refs #8818.

comment:9 Changed 8 years ago by robertm

Status: assignedinfoneeded

Kenni,

I build as root. If you'd like to attach the theme string diffs, I am happy to apply them.

Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

Attachment: themestrings.diff added

Themestrings diff

comment:10 Changed 8 years ago by Kenni Lund [kenni AT kelu d0t dk] <kenni@…>

Thanks Robert, I've attached the themestrings diffs.

comment:11 Changed 8 years ago by robertm

Resolution: fixed
Status: infoneededclosed

(In [25809]) Update core Myth themestrings to remove unwanted strings following our update of the run.sh script. Thanks to Kenni Lund for spotting the problem and providing the fixes. Fixes #8818.

comment:12 Changed 8 years ago by stuartm

Milestone: unknown0.24
Note: See TracTickets for help on using tickets.