win32 compilation broken, possible due to [26041]

[Jonathan Martens <jonathan@…>]

When compiling on windows against current trunk compilation halts with the following error:

g++ -enable-stdcall-fixup -Wl,-enable-auto-import -Wl,-enable-runtime-pseudo-rel
oc -shared -mthreads -Wl -Wl,--out-implib,liblibmythdb-0.23.a -o libmythdb-0.23.
dll object_script.libmythdb-0.23  -lpthread -lws2_32 -lavicap32 -lmp3lame -lm -l
freetype -lm -lpthread -lz -lpsapi -lws2_32 -lfreetype -L/D/mythtv/build//lib -L
D:/Qt/4.6.3/lib -lQtSqld4 -lQtXmld4 -lQtGuid4 -lQtNetworkd4 -lQtCored4
Creating library file: liblibmythdb-0.23.a./mythsystem.o: In function `Z22myth_s
ystem_post_flagsRiR15MythSystemLocks':
d:\mythtv\mythtv\libs\libmythdb/mythsystem.cpp:339: undefined reference to `Joys
tickMenuEventLock::~JoystickMenuEventLock()'
d:\mythtv\mythtv\libs\libmythdb/mythsystem.cpp:344: undefined reference to `Lirc
EventLock::~LircEventLock()'
./mythsystem.o: In function `Z21myth_system_pre_flagsRiR15MythSystemLocks':
d:\mythtv\mythtv\libs\libmythdb/mythsystem.cpp:316: undefined reference to `Joys
tickMenuEventLock::JoystickMenuEventLock(bool)'
d:\mythtv\mythtv\libs\libmythdb/mythsystem.cpp:311: undefined reference to `Lirc
EventLock::LircEventLock(bool
)'
collect2: ld returned 1 exit status
make[2]: *** [libmythdb-0.23.dll] Error 1
make[2]: Leaving directory `/D/mythtv/mythtv/libs/libmythdb'
make[1]: *** [sub-libmythdb-make_default] Error 2
make[1]: Leaving directory `/D/mythtv/mythtv/libs'
make: *** [libs] Error 2

I suspect that [26041] is the culprit.

[robertm]

Think you mean r26141, and I agree.

[beirdo]

(In [26143]) Ugh. Right. CONFIG_LIRC, CONFIG_JOYSTICK_MENU need #if, not #ifdef. When turned on, a value of 1, when off, a value of 0, but still defined.

Fixes #8871

[beirdo]

As an addition, I plan on getting my Windows build environment useful today. My apologies.

[Jonathan Martens <jonathan@…>]

Unfortunately I think there still is something wrong:

g++ -c -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -march=pentium4 -fomi
t-frame-pointer -g -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -Wno-non-
virtual-dtor -funit-at-a-time -Wmissing-declarations -D__STDC_CONSTANT_MACROS -D
__STDC_LIMIT_MACROS -O3 -frtti -fexceptions -mthreads -DQT_LARGEFILE_SUPPORT -DW
IN32 -DUSING_MINGW -DMMX -Di386 -D_GNU_SOURCE -DRUNPREFIX=\"..\" -DLIBDIRNAME=\"
lib\" -DQT_THREAD_SUPPORT -DQT_DLL -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_N
ETWORK_LIB -DQT_CORE_LIB -I'../../../../Qt/4.6.3/include/QtCore' -I'../../../../
Qt/4.6.3/include/QtNetwork' -I'../../../../Qt/4.6.3/include/QtGui' -I'../../../.
./Qt/4.6.3/include/QtXml' -I'../../../../Qt/4.6.3/include/QtSql' -I'../../../../
Qt/4.6.3/include' -I'/usr/include' -I'/D/mythtv/build/' -I'../libmythui' -I'..'
-I'../../../../Qt/4.6.3/include/ActiveQt' -I'.' -I'../../../../Qt/4.6.3/mkspecs/
win32-g++' -o mythcorecontext.o mythcorecontext.cpp
In file included from mythcorecontext.cpp:19:
mythsystem.h:20: error: ISO C++ forbids declaration of 'LircEventLock' with no t
ype
mythsystem.h:20: error: expected ';' before '*' token
mythsystem.h:23: error: ISO C++ forbids declaration of 'JoystickMenuEventLock' w
ith no type
mythsystem.h:23: error: expected ';' before '*' token
mythcorecontext.cpp: In member function 'void MythCoreContext::dispatchNow(const
 MythEvent&)':
mythcorecontext.cpp:1095: warning: 'void MythObservable::dispatchNow(const MythE
vent&)' is deprecated (declared at mythobservable.h:21)
make[2]: *** [mythcorecontext.o] Error 1
make[2]: Leaving directory `/D/mythtv/mythtv/libs/libmythdb'
make[1]: *** [sub-libmythdb-make_default] Error 2
make[1]: Leaving directory `/D/mythtv/mythtv/libs'
make: *** [libs] Error 2

[beirdo]

(In [26144]) Sigh. Missed a spot. I need coffee.

Fixes #8871 (again)

[Jonathan Martens <jonathan@…>]

Replying to beirdo:

(In [26144]) Sigh. Missed a spot. I need coffee.

Had your coffee? Ok, then continue reading ;-)

mythsystem.cpp: In function 'void myth_system_post_flags(int&, MythSystemLocks&)
':
mythsystem.cpp:338: error: 'struct MythSystemLocks' has no member named 'jsmenu'

mythsystem.cpp:339: error: 'struct MythSystemLocks' has no member named 'jsmenu'

mythsystem.cpp:340: error: 'struct MythSystemLocks' has no member named 'jsmenu'

mythsystem.cpp:343: error: 'struct MythSystemLocks' has no member named 'lirc'
mythsystem.cpp:344: error: 'struct MythSystemLocks' has no member named 'lirc'
mythsystem.cpp:345: error: 'struct MythSystemLocks' has no member named 'lirc'
make[2]: *** [mythsystem.o] Error 1
make[2]: Leaving directory `/D/mythtv/mythtv/libs/libmythdb'
make[1]: *** [sub-libmythdb-make_default] Error 2
make[1]: Leaving directory `/D/mythtv/mythtv/libs'
make: *** [libs] Error 2

[Jonathan Martens <jonathan@…>]

This seems to make libmythdb compile (at least). Compilation is still running...

[Jonathan Martens <jonathan@…>]

Forgot to re-open...

[beirdo]

(In [26145]) Make the cleanup/unlocking also require the CONFIG_ defines as conditionals.

Refs #8871

Please let this be all.

[beirdo]

Original reporter has indicated in IRC that this is now closed.