Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#8877 closed enhancement (fixed)

Add unique token check to protocol handshake

Reported by: wagnerrp Owned by: cpinkham
Priority: minor Milestone: 0.24
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch adds a randomly generated token to the MYTH_PROTO_VERSION call. The purpose of this is to provide a unique token for each protocol version to check against, to ensure the client actually speaks the proper protocol, and isn't simply responding with the version handed out by a previous connection. The current string is just a randomly generated 8-digit hex string.

This was motivated by a recent discussion in the mailing list where the 'libcmyth' library was touted as a well maintained interface for accessing MythTV, while it has not actually been updated since protocol version 44.

Attachments (1)

mythproto_vercheck.patch (7.0 KB) - added by wagnerrp 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by wagnerrp

comment:1 Changed 4 years ago by robertm

  • Status changed from new to assigned

comment:2 Changed 4 years ago by cpinkham

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [26280]) dd unique token check to protocol handshake in addition to the
MythTV protocol version. Clients will now be required to pass
in a unique token specific to that protocol version when
connecting to the backend.

NOTE: This does bump the protocol version, so update the core
of MythTV as well as MythWeb and the python and perl bindings.

Closes #8877 using patch by Raymond Wagner.

comment:3 Changed 4 years ago by cpinkham

(In [26281]) Add unique token check to protocol handshake in addition to the
MythTV protocol version. Clients will now be required to pass
in a unique token specific to that protocol version when
connecting to the backend.

NOTE: This does bump the protocol version, so update the core
of MythTV as well as MythWeb and the python and perl bindings.

References #8877.

This brings MythWeb up to date with trunk [26280].

comment:4 Changed 4 years ago by cpinkham

(In [26288]) Make the version mismatch error message a little more correct
now that the version mismatch could be either in the protocol
version or the token passed with the versoin number.

References #8877.

comment:5 Changed 4 years ago by cpinkham

(In [26296]) Combine some strings instead of letting the compiler try to determine
what the right thing to do is (which it didn't in this case).

Refs #8877.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.