Opened 9 years ago

Closed 9 years ago

#8892 closed defect (fixed)

PBB always generates new preview when the program list is updated

Reported by: stuartm Owned by: danielk
Priority: minor Milestone: 0.24
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

It appears that since the preview generator re-write that we always request a new preview image for in-progress recordings every time that recording it selected even when we have a satisfactory image. The expected behaviour is to grab one preview for an in-progress recording and maybe another once it finishes recording.

Attachments (2)

8892-v1.patch (6.5 KB) - added by danielk 9 years ago.
untested partial fix
8892-v2.patch (6.7 KB) - added by danielk 9 years ago.
This version actually runs if compiled.. still not really tested.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by robertm

Status: newassigned

comment:2 Changed 9 years ago by danielk

stuart, is there a large time difference between the frontend and backend?

Also, can you produce a -vplayback,network,file log for both the front and back ends?

comment:3 Changed 9 years ago by danielk

Summary: PBB always generates new preview for in-progress recordingPBB always generates new preview when the program list is updated

I've changed the summary. The movement of the selection appears to have been a red herring.

It appears to be the RECORDING_LIST change events are causing the the preview info to be cleared.

Changed 9 years ago by danielk

Attachment: 8892-v1.patch added

untested partial fix

Changed 9 years ago by danielk

Attachment: 8892-v2.patch added

This version actually runs if compiled.. still not really tested.

comment:4 Changed 9 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [26452]) Fixes #8892. Use the recstartts as the bookmark comparison timestamp when a recording does not have a bookmark and is still recording. This avoids repeatedly regenerating the preview for an in-progress recording as the last modified time is constantly being updated as we record (which is what we previously always used when there was no bookmark) so anything that caused us to check if the preview is out of date caused us to believe it was out of date.

Note: See TracTickets for help on using tickets.