Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#8900 closed patch (fixed)

Prefer FLAC to AC3

Reported by: anonymous Owned by: robertm
Priority: trivial Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: yes

Description

I have some MKVs with a FLAC and AC3 track. I'd like the FLAC track to be preferred. A better patch would also prefer PCM tracks to AC3.

Attachments (3)

mythtv_lpcm.patch (1.6 KB) - added by anonymous 9 years ago.
mythtv_default.patch (783 bytes) - added by anonymous 9 years ago.
prefer_flac_to_lossy_codecs.patch (1.2 KB) - added by anonymous 8 years ago.

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by anonymous

Attachment: mythtv_lpcm.patch added

comment:1 Changed 9 years ago by anonymous

MKVs seem to have a concept of a default track which MythTV appears to ignore. Respecting that would work as well.

comment:2 Changed 9 years ago by robertm

Priority: minortrivial
Severity: mediumlow
Status: newinfoneeded_new

FLAC is definitely not superior to all the other lossless audio codecs you put it above. (TrueHD, etc) Definitely can't make FLAC the "most preferred" audio track. Would accept a patch to use the default audio track from MKV, though.

comment:3 Changed 9 years ago by robertm

Owner: set to robertm

Changed 9 years ago by anonymous

Attachment: mythtv_default.patch added

comment:4 Changed 9 years ago by anonymous

Added a second patch to use the default audio track. Tested it by using mmg to edit the header of a MKV file.

comment:5 Changed 9 years ago by robertm

Milestone: unknown0.25
Status: infoneeded_newnew
Version: UnspecifiedTrunk Head

comment:6 Changed 9 years ago by robertm

Status: newassigned

comment:7 Changed 9 years ago by stuartm

Milestone: 0.25

Milestone 0.25 deleted

comment:8 Changed 8 years ago by anonymous

This more recent patch prefers TrueHD to FLAC to EAC3.

Changed 8 years ago by anonymous

comment:9 Changed 8 years ago by robertm

Resolution: Fixed
Status: assignedclosed

Fixed in 486d2c5.

comment:10 Changed 8 years ago by Robert McNamara

Resolution: Fixedfixed

Select the Default audio track if the container supports it.

Containers such as MKV permit one to define which audio track is primary, and using this flag means not going through the avformatdecoder guesswork we currently employ. This is courtesy an anonymous patch on #8900. I am uncomfortable with applying the part that prefers FLAC to E-AC3/DTS/AC3, though. There are a lot of people out there who encode secondary tracks to FLAC and do a straight copy of the lossy primary track. I just don't feel 100% on the idea of preferring it to other more commonplace codecs.

Fixes #8900.

Changeset: 486d2c5428c96d3f04b9f7d2646a823abf1bf1f7

comment:11 Changed 7 years ago by stuartm

Ticket locked: set
Note: See TracTickets for help on using tickets.