Opened 14 years ago
Closed 13 years ago
Last modified 12 years ago
#8900 closed patch (fixed)
Prefer FLAC to AC3
Reported by: | anonymous | Owned by: | robertm |
---|---|---|---|
Priority: | trivial | Milestone: | 0.25 |
Component: | MythTV - General | Version: | Master Head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | yes |
Description
I have some MKVs with a FLAC and AC3 track. I'd like the FLAC track to be preferred. A better patch would also prefer PCM tracks to AC3.
Attachments (3)
Change History (14)
Changed 14 years ago by
Attachment: | mythtv_lpcm.patch added |
---|
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Priority: | minor → trivial |
---|---|
Severity: | medium → low |
Status: | new → infoneeded_new |
FLAC is definitely not superior to all the other lossless audio codecs you put it above. (TrueHD, etc) Definitely can't make FLAC the "most preferred" audio track. Would accept a patch to use the default audio track from MKV, though.
comment:3 Changed 14 years ago by
Owner: | set to robertm |
---|
Changed 14 years ago by
Attachment: | mythtv_default.patch added |
---|
comment:4 Changed 14 years ago by
Added a second patch to use the default audio track. Tested it by using mmg to edit the header of a MKV file.
comment:5 Changed 14 years ago by
Milestone: | unknown → 0.25 |
---|---|
Status: | infoneeded_new → new |
Version: | Unspecified → Trunk Head |
comment:6 Changed 14 years ago by
Status: | new → assigned |
---|
Changed 13 years ago by
Attachment: | prefer_flac_to_lossy_codecs.patch added |
---|
comment:10 Changed 13 years ago by
Resolution: | Fixed → fixed |
---|
Select the Default audio track if the container supports it.
Containers such as MKV permit one to define which audio track is primary, and using this flag means not going through the avformatdecoder guesswork we currently employ. This is courtesy an anonymous patch on #8900. I am uncomfortable with applying the part that prefers FLAC to E-AC3/DTS/AC3, though. There are a lot of people out there who encode secondary tracks to FLAC and do a straight copy of the lossy primary track. I just don't feel 100% on the idea of preferring it to other more commonplace codecs.
Fixes #8900.
Changeset: 486d2c5428c96d3f04b9f7d2646a823abf1bf1f7
comment:11 Changed 12 years ago by
Ticket locked: | set |
---|
MKVs seem to have a concept of a default track which MythTV appears to ignore. Respecting that would work as well.