Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8908 closed defect (fixed)

Moved bits in the programflags field have not been updated in Mythweb

Reported by: david.madsen@… Owned by: danielk
Priority: minor Milestone: 0.24
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In changeset 24694 some of the bit positions of flags in the ProgramInfo? field were shifted around.

Mythweb contains it's own mapping of these bit positions which caused some of the fields to be interpreted incorrectly when viewing program information through mythweb.

The attached patch mirrors the current flag mappings from programtypes.h

Attachments (1)

fix_watched.patch (2.5 KB) - added by anonymous 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by anonymous

Attachment: fix_watched.patch added

comment:1 Changed 9 years ago by robertm

Status: newassigned

comment:2 Changed 9 years ago by anonymous

We should probably add a comment in the c++ code as well to make sure these stay in sync.

comment:3 Changed 9 years ago by stuartm

I'm a little surprised that these changed, especially since there was no database update fixing the programflags for existing recordings.

comment:4 Changed 9 years ago by stuartm

Milestone: unknown0.24
Owner: changed from Rob Smith to danielk

comment:5 Changed 9 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [26206]) Fixes #8908. MythWeb must by necessity use the raw programflags. So update the flags that changed in the PI refactor & add a comment to flag typedef to update modules/tv/classes/Program.php whenever the flags are updated.

comment:6 Changed 9 years ago by sphery

(In [26207]) Update the Perl bindings to use the new programflags values. Refs #8908.

Note: See TracTickets for help on using tickets.