Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9054 closed Patch - Bug Fix (Fixed)

Remove deprecated isNull checks for QStrings

Reported by: Ben Dailey <benddailey@…> Owned by: stuartm
Priority: minor Milestone: 0.25
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Attached patch removes unnecessary isNull checks from mythtv. I have compile tested and have not found any regressions with these changes.

Attachments (1)

remove_isNull_r26633.patch (20.8 KB) - added by Ben Dailey <benddailey@…> 9 years ago.
isNull removal patch against head r26633

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Ben Dailey <benddailey@…>

Attachment: remove_isNull_r26633.patch added

isNull removal patch against head r26633

comment:1 Changed 9 years ago by robertm

Owner: set to stuartm
Status: newassigned

comment:2 Changed 9 years ago by stuartm

Resolution: Fixed
Status: assignedclosed

(In [27401]) Remove a couple of redundant isNull() calls. isEmpty() returns true for null strings and strings are initialised to empty not null anyway. Patch by Ben Dailey. I've omitted the other changes in that patch, one was not as straightforward as it seems and the others were all in xmlparse.cpp which is deprecated code due for removal in 0.25. Closes #9054

comment:3 Changed 9 years ago by stuartm

Milestone: unknown0.25
Type: patchPatch - Bug Fix
Note: See TracTickets for help on using tickets.