Opened 9 years ago

Closed 9 years ago

#9115 closed defect (Fixed)

[25855] introduces second defintion of $version

Reported by: Jonathan Martens <jonathan@…> Owned by: Nigel
Priority: minor Milestone: unknown
Component: Ports - Windows Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

$version is defined on two places in the win32 packaging script, it should be removed around line 106 as its already defined at line 69.

Change History (9)

comment:1 Changed 9 years ago by Jonathan Martens <jonathan@…>

The same goes for the 0.24-fixes branch and 0.24-rc1 tag

comment:2 Changed 9 years ago by robertm

(In [26901]) Remove redundant declaration of version in Win32 packaging script, bump trunk version to .24 until we start naming libs .25 closer to that release. Refs #9115.

comment:3 Changed 9 years ago by robertm

Resolution: Fixed
Status: newclosed

(In [26902]) Bump .24-fixes win32 build script to a recent .24-fixes revision. update version numbers and remove redundant declaration of version. Fixes #9116. Fixes #9115.

comment:4 Changed 9 years ago by Nigel

Resolution: Fixed
Status: closednew

No, it wasn't defined in two places. Line 70 defines it, and line 106 changes it to the fixes branch if the -b option is defined.
I will add this back in, in a MythTV version-independant way.

Version 0, edited 9 years ago by Nigel (next)

comment:5 Changed 9 years ago by robertm

Status: newassigned

comment:6 Changed 9 years ago by Nigel

Looking more closely, that code didn't work anyway. 0.23-fixes was a branch, but 0.23.1 was a tag, so the code would need to download http://cvs.mythtv.org/trac/browser/tags/release-0-23-1/mythtv. I will add something back in as a comment, for the next time there is a -1

comment:7 Changed 9 years ago by Nigel

(In [27050]) Document later releases of branches (which are actually tags). Refs #9115.

comment:8 Changed 9 years ago by Nigel

(In [27051]) Backport of [27050] from trunk. Document later releases of branches (which are actually tags). Refs #9115.

comment:9 Changed 9 years ago by Nigel

Resolution: Fixed
Status: assignedclosed

(In [27052]) Backport of [27050] from trunk. Document later releases of branches (which are actually tags). Closes #9115.

Note: See TracTickets for help on using tickets.