Opened 9 years ago

Closed 9 years ago

#9135 closed defect (Fixed)

MythBuntu needs plugin checkbox on MythBrowser setup screen

Reported by: Jonathan Martens <jonathan@…> Owned by: paulh
Priority: minor Milestone: unknown
Component: Plugin - MythBrowser Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

While running the MythBuntu? team with 0.24-fixes I see the following in the log (-v "all"):

2010-10-22 14:33:44.613 XMLParseBase: Loading window theme from D:/mythtv/build/share/mythtv/themes/Mythbuntu/browser-ui.xml
2010-10-22 14:33:44.613 MythUIHelper: LoadCacheImage(cursor.png,cursor.png--1x26.png)
2010-10-22 14:33:44.613 MythUIImage(0x2d677b58): Load(), loading 'cursor.png' in foreground
2010-10-22 14:33:44.613 MythUIImage(0x2d677b58): LoadImage(cursor.png) Object cursor
2010-10-22 14:33:44.613 MythUIHelper: LoadCacheImage(cursor.png,cursor.png--1x26.png)
2010-10-22 14:33:44.613 MythUIImage(0x2d677b58): LoadImage found in cache :cursor.png--1x26.png: RefCount = 6
2010-10-22 14:33:44.613 MythUIHelper: LoadCacheImage(cursor.png,cursor.png--1x26.png)
2010-10-22 14:33:44.613 MythUIImage(0x2d69c5a8): Load(), loading 'cursor.png' in foreground
2010-10-22 14:33:44.613 MythUIImage(0x2d69c5a8): LoadImage(cursor.png) Object cursor
2010-10-22 14:33:44.613 MythUIHelper: LoadCacheImage(cursor.png,cursor.png--1x26.png)
2010-10-22 14:33:44.613 MythUIImage(0x2d69c5a8): LoadImage found in cache :cursor.png--1x26.png: RefCount = 7
2010-10-22 14:33:44.629 Theme is missing critical theme elements. 

In the dev mailinglist it was concluded that this must be due to the late implementation of the enable plugins checkbox and it was concluded that it should be raised as an issue in Trac. When I remove the offending browser-ui.xml file, so MythFrontend takes the one from the default theme the checkbox is visible and the error is no longer in the log file.

Attachments (4)

mythbuntu.pluginscheck.diff (812 bytes) - added by robertm 9 years ago.
mythbuntu.jpeg (200.7 KB) - added by Jonathan Martens <jonathan@…> 9 years ago.
screenshot after applying patch
mythbuntu.pluginscheck.2.diff (812 bytes) - added by robertm 9 years ago.
mythbuntu2.jpeg (200.0 KB) - added by Jonathan Martens <jonathan@…> 9 years ago.
screenshot after applying 2nd patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by robertm

Jonathan,

Please apply this patch and test, as well as taking a screenshot if possible. Can't test from work but this ought to do the trick.

Changed 9 years ago by robertm

Attachment: mythbuntu.pluginscheck.diff added

Changed 9 years ago by Jonathan Martens <jonathan@…>

Attachment: mythbuntu.jpeg added

screenshot after applying patch

comment:2 Changed 9 years ago by Jonathan Martens <jonathan@…>

The error is gone and the plugin checkbox and it's description are visible, not sure if the layout is the best with current patch though.

comment:3 Changed 9 years ago by robertm

Hi Jonathan,

Try this one, please.

Changed 9 years ago by robertm

Changed 9 years ago by Jonathan Martens <jonathan@…>

Attachment: mythbuntu2.jpeg added

screenshot after applying 2nd patch

comment:4 Changed 9 years ago by Jonathan Martens <jonathan@…>

Looks better IMHO

comment:5 Changed 9 years ago by robertm

(In [26953]) Add required checkbox to Mythbuntu theme. Unfortunately terminate the string with a colon to prevent new translation strings. To fix later. Refs #9135.

comment:6 Changed 9 years ago by robertm

Resolution: Fixed
Status: newclosed

(In [26954]) Backport r26953 to .24-fixes. Add required checkbox to Mythbuntu theme. Fixes #9135.

Note: See TracTickets for help on using tickets.