Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 4 years ago

Closed 3 years ago

#9139 closed defect (Fixed)

video rendered tilted 45 degrees when running mythfrontend with -w and an odd number of horizontal pixels.

Reported by: Johnny Stenback <mythtv-users@…> Owned by: markk
Priority: minor Milestone: 0.24.1
Component: MythTV - Video Playback Version: 0.24-fixes
Severity: medium Keywords:
Cc: danielk@… Ticket locked: no

Description

Not a big deal, but running mythfrontent -w -geometry 711x400 (or any other odd numbered width, height can be odd w/o causing problems) causes the video playback to be rendered tilted 45 degrees to the right, so you get a split in the video starting top-right going down into the screen at a 45 degree angle). I'm seeing this on a test system where I only have software rendering (vnc server), so not a big deal, but I figured this may come up in other situations where it might actually matter.

This used to work in 0.23, broken in 0.24.

Attachments (0)

Change History (4)

comment:1 Changed 4 years ago by danielk

  • Cc danielk@… added
  • Component changed from MythTV - General to MythTV - Video Playback
  • Owner set to markk
  • Status changed from new to assigned

Which video render is this happening with?

This can occur when some element of the video pipeline assumes a direct relationship between the width and the stride or when a buffer allocation is not rounded up to the nearest dimension as required by the codec or the buffer's color model. Generally when such an error is made we end up painting past the end of the buffer which can cause segfaults, but we add protective padding at the end of our buffer allocations which should avoid such a segfault in most cases.

comment:2 Changed 4 years ago by anonymous

I'm seeing this with both the Qt and the OpenGL paint engines (just tested), but I typically use the Qt painter here (as there is no graphics hardware at all in this case, just a dumb vnc X server). I have not seen any segfaults due to this that I can recall.

comment:3 Changed 3 years ago by markk

(In [27392]) Ensure the X image created in the Xlib 'fallback' video renderer is the
same size as the buffer created for software based conversion and
scaling.

Refs #9139

comment:4 Changed 3 years ago by markk

  • Milestone changed from unknown to 0.24.1
  • Resolution set to Fixed
  • Status changed from assigned to closed
  • Version changed from Unspecified to 0.24-fixes

Fixed in r27393

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.