Opened 13 years ago

Closed 13 years ago

#9192 closed defect (Fixed)

CC608 "clear display" codes are not processed correctly

Reported by: gregorio.gervasio@… Owned by: markk
Priority: minor Milestone: 0.24
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

EIA-608 closed captions are being displayed too long (usually until the caption changes). This isn't usually a big problem except for cases where the captioner has explicitly cleared the captions to avoid obscuring some on-screen graphic.

I think this problem was introduced when the OSD was ported to MythUI. In CC608Reader::Update, the captions should be cleared when "subtitle.clr == 0 && subtitle.len == 0". However, SubtitleScreen::DisplayCC608Subtitles does not update the display when this happens.

The attached patch seems to fix the problem.

Attachments (1)

cc_clr-r27113.patch​ (414 bytes) - added by gregorio.gervasio@… 13 years ago.
(release-0-24-fixes) fix clearing of CC608 subtitles

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by gregorio.gervasio@…

Attachment: cc_clr-r27113.patch​ added

(release-0-24-fixes) fix clearing of CC608 subtitles

comment:1 Changed 13 years ago by markk

Milestone: unknown → 0.24
Owner: set to markk
Status: new → accepted
Version: Unspecified → Trunk Head

comment:2 Changed 13 years ago by markk

Resolution: → Fixed
Status: accepted → closed

(In [27118]) Clear CC608 captions if they are empty.

Closes #9192

Doesn't appear to make any difference to my limited set of test clips - so please shout if it causes unexpected issues.

Note: See TracTickets for help on using tickets.