Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#9213 closed Bug Report - General (fixed)

Skip backwards no longer skips "through" a cut list

Reported by: mythtv@… Owned by: Jim Stichnoth
Priority: minor Milestone: 0.25
Component: MythTV - Video Playback Version: 0.24-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

Minor regression from 0.23-fixes to 0.24-fixes.

In 0.23-fixes, if you have a cut list defined for a video, then you end up at the end of a cut point (for example, after it skips the commercials), if you try to skip backwards in the video, it will actually skip past the previous cut list and play video shortly before the cut point (my guess would be whatever you have set as the rewind amount, such as 5 seconds).

In 0.24-fixes, it will no longer skip past the cut point. It will only skip back to the end of that cut point, thus making it impossible to "skip backwards" through a cut point. If you do a large jump (such as a 10 minute jump), it will skip past it fine, but then you are really far away from where you were trying to go.

My guess is that 0.24-fixes is now just performing a simple frame count calculation to determine where to skip, ignoring the cut list. When you skip backwards, it resumes play from inside a defined cut list, then skips to the end of that cut point to resume.

It would be awesome to have the 0.23-fixes functionality back.

Attachments (1)

9213_v1.patch (957 bytes) - added by Jim Stichnoth <stichnot@…> 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by Jim Stichnoth <stichnot@…>

FWIW, part of the patch in #8631 fixes this.

comment:2 Changed 9 years ago by robertm

Owner: changed from Janne Grunau to markk
Status: newassigned

comment:3 Changed 9 years ago by sphery

Owner: changed from markk to sphery
Status: assignedaccepted

comment:4 Changed 8 years ago by stuartm

Milestone: unknown0.25
Status: acceptedinfoneeded
Type: defectBug Report - General

Jim, can you break out the bit which fixes this bug and attach to this ticket? Or was it what Taylor already committed?

comment:5 Changed 8 years ago by Jim Stichnoth <stichnot@…>

I looked into this, and the problem still exists in Master. It would be possible to remove the code in the #8631 patch that deals with alternate keybindings, OSD, and jumping to an absolute time, leaving only the code related to relative jumping, but the resulting user experience could be inconsistent and confusing in places (I can give examples if requested). Basically, #8631 needs to be applied all or nothing for a consistent user experience.

Instead, I attached a patch that skips to 3 seconds before the start of the cut region if you try to jump backward into a cut region.

Changed 8 years ago by Jim Stichnoth <stichnot@…>

Attachment: 9213_v1.patch added

comment:6 Changed 8 years ago by robertm

Status: infoneededassigned

comment:7 Changed 8 years ago by Jim Stichnoth

Owner: changed from sphery to Jim Stichnoth

comment:8 Changed 8 years ago by Github

Resolution: fixed
Status: assignedclosed

Fix seeking backwards into a cut region.

When skipping backwards and ending up in a cut region, move instead to 5 seconds before the beginning of the cut region. This isn't a perfect solution, but it fixes 99.99% of the problem. A more robust solution will be implemented post 0.25.

Fixes #9213.

Branch: master Changeset: 89c34ef6b2e0e8688474ef546b799d54d8ec6242

comment:9 Changed 8 years ago by Jim Stichnoth <jstichnoth@…>

In ed316911fd32bf31def19705adc1057f6b0dc9d1/mythtv:

Revert "Fix seeking backwards into a cut region."

This reverts commit 89c34ef6b2e0e8688474ef546b799d54d8ec6242.

This is no longer needed after f0b202909eaeb963a6c3648f9eb45ab3e95ba159.

Refs #8631. Refs #9213.

Note: See TracTickets for help on using tickets.