Opened 13 years ago
Closed 13 years ago
Last modified 13 years ago
#9242 closed Patch - Bug Fix (Fixed)
[PATCH] Windows OpenGL video playback broken
Reported by: | Owned by: | markk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.24.1 |
Component: | Ports - Windows | Version: | Master Head |
Severity: | high | Keywords: | OpenGL windows video |
Cc: | Ticket locked: | no |
Description
On Windows, MythTV has a setting to select OpenGL as the current video renderer. Unfortunately, tv & video playback is broken on my Win32 systems (Win2k and WinXP with Nvidia GTS 2 Pro graphics) together with Wine 1.3.6 and VirtualBox? 3.2.10. The attached patch enables video on all these systems.
Attachments (1)
Change History (5)
Changed 13 years ago by
Attachment: | win32-opengl.diff added |
---|
comment:1 Changed 13 years ago by
Owner: | changed from Nigel to markk |
---|---|
Status: | new → assigned |
comment:3 Changed 13 years ago by
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
(In [27292]) Backport r27281 from trunk to release-0-24-fixes
Don't call QGLContext::doneCurrent() in MythRenderOpenGL.
- it should be unnecessary given that makeCurrent always checks the
correct context is current to the current thread and following the threading changes, all of our OpenGL usage should be in the same thread.
- it breaks playback on certain Windows builds.
- it has a sizeable performance impact on at least one Intel system.
Closes #9242
comment:4 Changed 13 years ago by
Milestone: | unknown → 0.24.1 |
---|
OpenGL Windows video fix