Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9242 closed Patch - Bug Fix (Fixed)

[PATCH] Windows OpenGL video playback broken

Reported by: Lawrence Rust <lvr@…> Owned by: markk
Priority: minor Milestone: 0.24.1
Component: Ports - Windows Version: Master Head
Severity: high Keywords: OpenGL windows video
Cc: Ticket locked: no

Description

On Windows, MythTV has a setting to select OpenGL as the current video renderer. Unfortunately, tv & video playback is broken on my Win32 systems (Win2k and WinXP with Nvidia GTS 2 Pro graphics) together with Wine 1.3.6 and VirtualBox? 3.2.10. The attached patch enables video on all these systems.

Attachments (1)

win32-opengl.diff (589 bytes) - added by Lawrence Rust <lvr@…> 8 years ago.
OpenGL Windows video fix

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Lawrence Rust <lvr@…>

Attachment: win32-opengl.diff added

OpenGL Windows video fix

comment:1 Changed 8 years ago by beirdo

Owner: changed from Nigel to markk
Status: newassigned

comment:2 Changed 8 years ago by markk

see r27281

comment:3 Changed 8 years ago by markk

Resolution: Fixed
Status: assignedclosed

(In [27292]) Backport r27281 from trunk to release-0-24-fixes

Don't call QGLContext::doneCurrent() in MythRenderOpenGL.

  • it should be unnecessary given that makeCurrent always checks the

correct context is current to the current thread and following the threading changes, all of our OpenGL usage should be in the same thread.

  • it breaks playback on certain Windows builds.
  • it has a sizeable performance impact on at least one Intel system.

Closes #9242

comment:4 Changed 8 years ago by Kenni Lund [kenni a kelu dot dk]

Milestone: unknown0.24.1
Note: See TracTickets for help on using tickets.