Opened 13 years ago
Closed 13 years ago
#9403 closed Bug Report (fixed)
Mythmusic doesn't properly handle failure to open audio device
Reported by: | JYA | Owned by: | paulh |
---|---|---|---|
Priority: | minor | Milestone: | 0.25 |
Component: | Plugin - MythMusic | Version: | Unspecified |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
mythmusic should handle properly when the audio device failed to be opened.
Right now it just assumes that everything is always good.
the comment: TODO: Error checking that device is opened correctly! (it has been there for almost 4 years :) )
This causes several issues later on from segfault to floating point exception (such as requesting timecode when the samplerate is == 0).
When OpenAudio? returns an error, no member of the class should ever be called.
I have put some handling to prevent some of the issues, but those are fixes for a situation that should never have occurred anyway.
Change History (3)
comment:1 Changed 13 years ago by
Owner: | changed from paulh to JYA |
---|---|
Status: | new → assigned |
comment:2 Changed 13 years ago by
Owner: | changed from JYA to paulh |
---|
comment:3 Changed 13 years ago by
Milestone: | unknown → 0.25 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
MythMusic: Check the audio output was opened without error before using it.
Fixes #9403.
Branch: master Changeset: 750bdf1392b52108e6f0104ee98c9bf2f34df438
I would have done so myself if it wasn't so tightly link to what the whole code is doing.
as such, the original author is the best person to do so...
I added a message to nag the user of the audio framework for not doing things properly!