Opened 5 years ago
Closed 5 years ago
Mythmusic doesn't properly handle failure to open audio device
|Reported by:||jyavenard||Owned by:||paulh|
|Component:||Plugin - MythMusic||Version:||Unspecified|
mythmusic should handle properly when the audio device failed to be opened.
Right now it just assumes that everything is always good.
the comment: TODO: Error checking that device is opened correctly! (it has been there for almost 4 years :) )
This causes several issues later on from segfault to floating point exception (such as requesting timecode when the samplerate is == 0).
When OpenAudio? returns an error, no member of the class should ever be called.
I have put some handling to prevent some of the issues, but those are fixes for a situation that should never have occurred anyway.
Change History (3)
comment:1 Changed 5 years ago by paulh
- Owner changed from paulh to jyavenard
- Status changed from new to assigned
comment:2 Changed 5 years ago by jyavenard
- Owner changed from jyavenard to paulh
comment:3 Changed 5 years ago by Github
- Milestone changed from unknown to 0.25
- Resolution set to fixed
- Status changed from assigned to closed