Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#9430 closed Bug Report (fixed)

RemoveDirectory name clash

Reported by: Lawrence Rust <lvr@…> Owned by: beirdo
Priority: minor Milestone: 0.25
Component: MythTV - MythSystem Version: Master Head
Severity: medium Keywords: RemoveDirectory Windows
Cc: Ticket locked: no

Description

In commit e090e97d2e422e91c289b8728dca674ae4529efb the function RemoveDirectory? was added. Unfortunately the same name is #defined in <windows.h> to have either a W or A suffix depending on UNICODE. This causes Windows builds of MythArchive? to fail with unresolved references to RemoveDirectoryW.

A pragmatic solution is to #undef RemoveDirectory? in libs/linmyth/util,cpp just before its definition and to do the same just before the inclusion of util.h in mythplugins/mytharchive/mytharchivehelper/main.cpp and mythplugins/mytharchive/mytharchive/mythburn.cpp.

A more elegant solution would be to rename it to say MythRemoveDirectory?.

Change History (6)

comment:1 Changed 9 years ago by beirdo

Owner: changed from paulh to beirdo
Status: newassigned

comment:2 Changed 9 years ago by beirdo

Component: Plugin - MythArchiveMythTV - MythSystem

comment:3 Changed 9 years ago by beirdo

Funny how this compiled for me in my testing, but very good catch. I'll change this today.

comment:4 Changed 9 years ago by beirdo

Resolution: Fixed
Status: assignedclosed

Fixed in SHA1 67b5e73

comment:5 Changed 9 years ago by Gavin Hurlbut

Resolution: Fixedfixed

comment:6 Changed 8 years ago by Raymond Wagner

Milestone: unknown0.25
Note: See TracTickets for help on using tickets.