Opened 13 years ago
Closed 13 years ago
Last modified 13 years ago
#9430 closed Bug Report (fixed)
RemoveDirectory name clash
| Reported by: | Owned by: | beirdo | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | MythTV - MythSystem | Version: | Master Head |
| Severity: | medium | Keywords: | RemoveDirectory Windows |
| Cc: | Ticket locked: | no |
Description
In commit e090e97d2e422e91c289b8728dca674ae4529efb the function RemoveDirectory? was added. Unfortunately the same name is #defined in <windows.h> to have either a W or A suffix depending on UNICODE. This causes Windows builds of MythArchive? to fail with unresolved references to RemoveDirectoryW.
A pragmatic solution is to #undef RemoveDirectory? in libs/linmyth/util,cpp just before its definition and to do the same just before the inclusion of util.h in mythplugins/mytharchive/mytharchivehelper/main.cpp and mythplugins/mytharchive/mytharchive/mythburn.cpp.
A more elegant solution would be to rename it to say MythRemoveDirectory?.
Change History (6)
comment:1 Changed 13 years ago by
| Owner: | changed from paulh to beirdo |
|---|---|
| Status: | new → assigned |
comment:2 Changed 13 years ago by
| Component: | Plugin - MythArchive → MythTV - MythSystem |
|---|
comment:3 Changed 13 years ago by
comment:4 Changed 13 years ago by
| Resolution: | → Fixed |
|---|---|
| Status: | assigned → closed |
Fixed in SHA1 67b5e73
comment:5 Changed 13 years ago by
| Resolution: | Fixed → fixed |
|---|
Renamed RemoveDirectory? to MythRemoveDirectory?
Closes #9430
Changeset: 67b5e73d1381bd9c4a8e4e7e85de4d6cbc369b6f
comment:6 Changed 13 years ago by
| Milestone: | unknown → 0.25 |
|---|
Funny how this compiled for me in my testing, but very good catch. I'll change this today.