Opened 10 years ago

Closed 10 years ago

#9434 closed Bug Report (Fixed)

Mythcommflag incorrectly saves to filemarkup table when video storage group is imbedded in another storage group dir

Reported by: philipn@… Owned by: cpinkham
Priority: minor Milestone: 0.24.1
Component: MythTV - General Version: 0.24-fixes
Severity: medium Keywords: mythcommflag storagegroups
Cc: Ticket locked: no


When the mythvideo storage group is imbedded in another storage group dir, the file markup table is not properly updated.

e.g. Storage Group (Not Myth Video) = /MythTV/Drive_5

Mythvideo Storage Group = /MythTV/Drive_5/MythVideo

file to transcode = MyVideo?.mpg Full path is /MythTV/Drive_5/MythVideo/MyVideo.mpg

Markup table is saved with /MythVideo/MyVideo?.mpg instead of MyVideo?.mpg

I have attached a patch to storagegroup.cpp to fix this.

Attachments (1)

StorageGroupChange.diff (1.5 KB) - added by philipn@… 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by philipn@…

Attachment: StorageGroupChange.diff added

comment:1 Changed 10 years ago by cpinkham

Owner: set to cpinkham
Status: newassigned

Creating a one-off solution like this patch does it not acceptable. What happens if users 'embed' Storage Groups other than 'Videos'? If you can come up with a patch that supports this functionality and is generic and will work for all Storage Groups then I'll look at applying it.

You might be able to achieve the desired functionality by just replacing this SQL Query:

SELECT DISTINCT dirname FROM storagegroup;

with this:

SELECT DISTINCT dirname FROM storagegroup ORDER BY dirname DESC;

I haven't tested that, but think that it may fix your issue. If it does, please report back and I can make that change in git.

comment:2 Changed 10 years ago by philipn@…

Yes, this fixes the issue as well. Thank you.

comment:3 Changed 10 years ago by cpinkham

Milestone: unknown0.24.1
Resolution: Fixed
Status: assignedclosed

This was fixed (but the wrong ticket number was referenced) in master in SHA1 68fa6e8 and in 0.24-fixes in SHA1 e15a45e.

Note: See TracTickets for help on using tickets.