Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9477 closed Patch - Bug Fix (fixed)

[PATCH] libmythui: compilation fails with disable-X11

Reported by: Lawrence Rust <lvr@…> Owned by: nigel
Priority: minor Milestone: 0.25
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If ./configure is run with --disable-X11 on a Linux system then compilation of libmythui/mythdisplay.cpp fails with an undefined reference to OpenMythXDisplay(). This is because Q_WS_X11 is defined by Qmake but mythxdisplay.h conditionally defines OpenMythXDisplay() dependent on USING_X11. This patch adds USING_X11 to the conditional in mythdisplay.cpp

Attachments (1)

30-mythdisplay.diff (495 bytes) - added by Lawrence Rust <lvr@…> 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by Lawrence Rust <lvr@…>

comment:1 Changed 3 years ago by nigel

  • Owner changed from stuartm to nigel
  • Status changed from new to assigned

Lawrence, thanks for finding this fault, and the patch. As mentioned in 9323343, 7e621b62d changed USING_X11 in mythxdisplay.cpp to Q_WS_X11 in mythdisplay.cpp. I will to a few test configure/builds, but suspect USING_X11 is the correct fix.

comment:2 Changed 3 years ago by nigel

  • Resolution set to Fixed
  • Status changed from assigned to closed

Fixed in 8f6f7aa7a? (untested on Windows, or Linux DirectFB)

Last edited 3 years ago by nigel (previous) (diff)

comment:3 Changed 3 years ago by Nigel Pearson

  • Resolution changed from Fixed to fixed

Re-enable --disable-x11 builds

Slightly changes a symbol used in [7e621b62d]. Closes #9477.
Only tested on Linux and Mac OS X.

Changeset: 8f6f7aa7a095863e9d9694347ee0839c755400cd

comment:4 Changed 3 years ago by wagnerrp

  • Milestone changed from unknown to 0.25
  • Version changed from Unspecified to Trunk Head

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.