Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#9477 closed Patch - Bug Fix (fixed)

[PATCH] libmythui: compilation fails with disable-X11

Reported by: Lawrence Rust <lvr@…> Owned by: Nigel
Priority: minor Milestone: 0.25
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If ./configure is run with --disable-X11 on a Linux system then compilation of libmythui/mythdisplay.cpp fails with an undefined reference to OpenMythXDisplay(). This is because Q_WS_X11 is defined by Qmake but mythxdisplay.h conditionally defines OpenMythXDisplay() dependent on USING_X11. This patch adds USING_X11 to the conditional in mythdisplay.cpp

Attachments (1)

30-mythdisplay.diff (495 bytes) - added by Lawrence Rust <lvr@…> 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Lawrence Rust <lvr@…>

Attachment: 30-mythdisplay.diff added

comment:1 Changed 8 years ago by Nigel

Owner: changed from stuartm to Nigel
Status: newassigned

Lawrence, thanks for finding this fault, and the patch. As mentioned in 9323343, 7e621b62d changed USING_X11 in mythxdisplay.cpp to Q_WS_X11 in mythdisplay.cpp. I will to a few test configure/builds, but suspect USING_X11 is the correct fix.

comment:2 Changed 8 years ago by Nigel

Resolution: Fixed
Status: assignedclosed

Fixed in 8f6f7aa7a? (untested on Windows, or Linux DirectFB)

Last edited 8 years ago by Nigel (previous) (diff)

comment:3 Changed 8 years ago by Nigel Pearson

Resolution: Fixedfixed

Re-enable --disable-x11 builds

Slightly changes a symbol used in [7e621b62d]. Closes #9477. Only tested on Linux and Mac OS X.

Changeset: 8f6f7aa7a095863e9d9694347ee0839c755400cd

comment:4 Changed 7 years ago by Raymond Wagner

Milestone: unknown0.25
Version: UnspecifiedTrunk Head
Note: See TracTickets for help on using tickets.