Opened 13 years ago
Closed 13 years ago
Last modified 13 years ago
#9477 closed Patch - Bug Fix (fixed)
[PATCH] libmythui: compilation fails with disable-X11
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | minor | Milestone: | 0.25 |
Component: | MythTV - User Interface Library | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
If ./configure is run with --disable-X11 on a Linux system then compilation of libmythui/mythdisplay.cpp fails with an undefined reference to OpenMythXDisplay(). This is because Q_WS_X11 is defined by Qmake but mythxdisplay.h conditionally defines OpenMythXDisplay() dependent on USING_X11. This patch adds USING_X11 to the conditional in mythdisplay.cpp
Attachments (1)
Change History (5)
Changed 13 years ago by
Attachment: | 30-mythdisplay.diff added |
---|
comment:1 Changed 13 years ago by
Owner: | changed from stuartm to Nigel |
---|---|
Status: | new → assigned |
comment:2 Changed 13 years ago by
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
Fixed in 8f6f7aa7a? (untested on Windows, or Linux DirectFB)
comment:3 Changed 13 years ago by
Resolution: | Fixed → fixed |
---|
Re-enable --disable-x11 builds
Slightly changes a symbol used in [7e621b62d]. Closes #9477. Only tested on Linux and Mac OS X.
Changeset: 8f6f7aa7a095863e9d9694347ee0839c755400cd
comment:4 Changed 13 years ago by
Milestone: | unknown → 0.25 |
---|---|
Version: | Unspecified → Trunk Head |
Lawrence, thanks for finding this fault, and the patch. As mentioned in 9323343, 7e621b62d changed USING_X11 in mythxdisplay.cpp to Q_WS_X11 in mythdisplay.cpp. I will to a few test configure/builds, but suspect USING_X11 is the correct fix.