Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9486 closed Bug Report (Fixed)

MythArchive 0.24-fixes: Sorting broken in 'Select Recordings'

Reported by: J.Pilk@… Owned by:
Priority: minor Milestone: 0.24.1
Component: Plugin - MythArchive Version: 0.24-fixes
Severity: medium Keywords:
Cc: Ticket locked: no


In 0.23-fixes the 'Select Recordings' screen was sorted by date, most recent first. In 0.24-fixes, at first, this order was reversed. After a few days in use I can't see any logic in the order of listing in 'All Recordings' mode. With that mode inactive, sort order is by title, but multiple programmes in a series are shown unsorted. I don't know of any way for a user to change the sort order.

First reported on the myth-users list, 11 Jan, with a comment that it would be nice to have sorting modes match 'Watch Recordings'. No responses.

Change History (4)

comment:1 Changed 10 years ago by sphery

Component: MythTV - GeneralPlugin - MythArchive
Milestone: unknown0.25
Resolution: Fixed
Status: newclosed

Fixed by 8992b86d8 and e965e4bab (in unstable/development/master only after Mar 5, 2011). Thanks to Paul H. for noticing.

In e965e4bab:

Rework the QUERY_RECORDINGS sort.

Modify QUERY_RECORDINGS to allow retrieving sorted or unsorted lists. The argument may be one of Recording (for in-progress recordings only, unsorted), or Unsorted, Ascending, or Descending (where the latter 3 request all recordings and specify sort order, based on starttime). This allows code that needs to sort the recording list itself, like the PlaybackBox? code, to request and unsorted list, while still allowing bindings and MythXML users to get sorted lists.

Change includes a binary version change, so plugin rebuild is required. Also includes a protocol version change, so all clients--frontends, backends, MythWeb--need updating.

comment:2 Changed 10 years ago by Github

Sort recordings for bindings and MythArchive?.

This change causes ProgramInfo::LoadFromRecorded?() to always sort recordings according to starttime (descending) in 0.24-fixes (only). A better fix was committed to master, but due to the binary version and protocol version changes, can't be backported to 0.24-fixes. This approach will make the list more usable for MythArchive? and bindings users, but without any version changes.

Refs #9486.

Changeset: 0bbd75b72a2e4a0ac79662a4484797ccce4b37fe

comment:3 Changed 10 years ago by sphery


Should have said "Fixes #9486" so the milestone would have been set automatically.

comment:4 Changed 10 years ago by J.Pilk@…

The changeset of comment 2 reached the ATrpms builds of 0.24-fixes a few days ago and works as advertised; thanks, Mike (and Axel).

MythTV Version : v0.24-250-g56c54fa MythTV Branch : fixes/0.24 Network Protocol : 63 Library API : 0.24.20101129-1 QT Version : 4.6.3

Note: See TracTickets for help on using tickets.