Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9488 closed Patch - Bug Fix (fixed)

convert version.sh for git versions that don't support the --dirty option

Reported by: yiannividalis@… Owned by: beirdo
Priority: minor Milestone: 0.24.1
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi,

I wrote in the lists http://www.gossamer-threads.com/lists/mythtv/users/468453 about my git version not supporting the 'dirty' option.

I patched version.sh so that it returns the 'git describe' without the 'dirty' option instead of just Unknown.

If it is acceptable, I am offering the patch

Yianni

Attachments (1)

vers.diff (358 bytes) - added by yianniv 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by yianniv

comment:1 Changed 3 years ago by beirdo

This is a very poor fix for the problem at hand. You should be using a newer version of git. We don't support anything older than git 1.7.x. I will however put a modified version of this in place.

comment:2 Changed 3 years ago by beirdo

  • Milestone changed from unknown to 0.24.1
  • Owner set to beirdo
  • Status changed from new to assigned

Modified version committed in 7af8c9a5bc6d (on master) and ffb13127ad14 (on fixes/0.24)

comment:3 Changed 3 years ago by beirdo

  • Resolution set to Fixed
  • Status changed from assigned to closed

comment:4 Changed 3 years ago by beirdo

Make that 3f991fa41a030c on fixes/0.24, my bad.

comment:5 Changed 3 years ago by Gavin Hurlbut

  • Resolution changed from Fixed to fixed

Allow braindead old git versions to give version

Since some people insist on using old versions of git (earlier than 1.7.x) that
don't support git describe --dirty, I'm putting in a fallback.

Thanks to yiannividalis@… for the idea

Closes #9488

Changeset: 7af8c9a5bc6dff87c02783c34d872e21ee8b0101

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.