Opened 13 years ago
Closed 13 years ago
Last modified 13 years ago
#9488 closed Patch - Bug Fix (fixed)
convert version.sh for git versions that don't support the --dirty option
Reported by: | Owned by: | beirdo | |
---|---|---|---|
Priority: | minor | Milestone: | 0.24.1 |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Hi,
I wrote in the lists http://www.gossamer-threads.com/lists/mythtv/users/468453 about my git version not supporting the 'dirty' option.
I patched version.sh so that it returns the 'git describe' without the 'dirty' option instead of just Unknown.
If it is acceptable, I am offering the patch
Yianni
Attachments (1)
Change History (6)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Milestone: | unknown → 0.24.1 |
---|---|
Owner: | set to beirdo |
Status: | new → assigned |
Modified version committed in 7af8c9a5bc6d (on master) and ffb13127ad14 (on fixes/0.24)
comment:3 Changed 13 years ago by
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
comment:5 Changed 13 years ago by
Resolution: | Fixed → fixed |
---|
Allow braindead old git versions to give version
Since some people insist on using old versions of git (earlier than 1.7.x) that don't support git describe --dirty, I'm putting in a fallback.
Thanks to yiannividalis@… for the idea
Closes #9488
Changeset: 7af8c9a5bc6dff87c02783c34d872e21ee8b0101
This is a very poor fix for the problem at hand. You should be using a newer version of git. We don't support anything older than git 1.7.x. I will however put a modified version of this in place.