Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#9535 closed Patch - Feature (fixed)

Minor cleanup after #8901

Reported by: Jim Stichnoth <stichnot@…> Owned by: sphery
Priority: minor Milestone: 0.25
Component: MythTV - Video Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

After the changes in #8901, the PlayerContext? argument to most DeleteMap? methods is now redundant since the PlayerContext? pointer is now cached in the DeleteMap? object. This patch provides the cleanup.

Attachments (1)

8901_cleanup.patch (13.1 KB) - added by Jim Stichnoth <stichnot@…> 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Jim Stichnoth <stichnot@…>

Attachment: 8901_cleanup.patch added

comment:1 Changed 8 years ago by sphery

Owner: changed from Janne Grunau to sphery
Status: newaccepted

comment:2 Changed 7 years ago by Github

Milestone: unknown0.25
Resolution: fixed
Status: acceptedclosed

Clean up PlayerContext? usage after editor undo/redo feature.

Remove redundant PlayerContext? function arguments after PlayerContext? was made a DeleteMap? member variable in 0791662a7.

Closes #9535.

Signed-off-by: Michael T. Dean <mdean@…>

Branch: master Changeset: 143bd71be80d7b9a31f64c9e6389fced6aec224f

comment:3 Changed 7 years ago by Github

Fix saving edits after editor cleanup.

Leftover argument caused edits to save as "autosave" lists, so that they weren't actually applied during playback, but looked correct in editing.

Refs #9535

Signed-off-by: Michael T. Dean <mdean@…>

Branch: master Changeset: 05b8be76e24adf30fbf6e3a5b19cc1cc057feb21

Note: See TracTickets for help on using tickets.