Opened 8 years ago
Closed 7 years ago
#9544 closed Patch - Bug Fix (Fixed)
MythCenter missing Watched icon
| Reported by: | Owned by: | kkhupal | |
|---|---|---|---|
| Priority: | trivial | Milestone: | unknown |
| Component: | Themes | Version: | 0.24-fixes |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The Watched icon is missing from the MythCenter? theme (apparently has been for a while). On further inspection, it seems that it actually is in recordings-ui.xml but commented out. I uncommented it and it seems to work fine--it appears in the same location as the bookmark icon, so it either has a bookmark or it's been watched, which seems fine to me. The attached trivial patch should take care of it. MythCenter?-wide also has those lines commented out, and the same patch should also apply cleanly, but I haven't tested its behavior.
Attachments (1)
Change History (3)
Changed 8 years ago by
| Attachment: | MythCenter-watched-icon.patch added |
|---|
comment:1 Changed 8 years ago by
| Owner: | set to kkhupal |
|---|---|
| Status: | new → assigned |
MythCenter? used to show the watched icon for each item in the program list which makes it easy to see at a glance which episode have been watch, the wide version still works that way. It looks like kkhupal removed the watched statetype from the list when he worked on it some time ago. Having it show in the status icons would be better than nothing but isn't ideal since it hides the bookmark state type.
Kevin do you mind looking at this since you seem to be the most interested in the non wide MythCenter?.
comment:2 Changed 7 years ago by
| Resolution: | → Fixed |
|---|---|
| Status: | assigned → closed |
This seems to have been fixed by Kevin in master in b3db7b984 . For now, I'm closing this as fixed, but will leave it up to Kevin whether to apply this patch to 0.24-fixes, or to backport some or all of b3db7b984 , or neither.
Patch to enable Watched icon on recordings screen