Opened 9 years ago

Last modified 8 years ago

#9556 accepted Patch - Feature

[PATCH] Updated enhanced cutpoint edit functionality patch

Reported by: Bill Stuff <billstuff2001@…> Owned by: Jim Stichnoth
Priority: minor Milestone: unknown
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This is an update of #6322 - It adds a new visual display for editing recordings (see attached picture)

To use it, go into the normal edit mode and hit the MENU button ('M' ??). The rest of the keys are similar to normal editing. The pictures at the bottom of the screen are the previous and next frames by seekamount (i.e. if you're seeking by 20 seconds, they're -60, -40, -20, 0, +20, +40, +60) Hit Esc or MENU to go back.

This is against 0.24. AFAIK it should work with trunk but it doesn't apply because of the recent undo/redo changes in the DeleteMap?. If there's any interest in putting this into trunk I'll help clean it up.

This is development code so it might not work perfectly but it shouldn't do anything bad. YMMV

Attachments (4)

bball.jpg (34.0 KB) - added by Bill Stuff <billstuff2001@…> 9 years ago.
Screenshot
EditGrid.all.1.patch (127.3 KB) - added by Bill Stuff <billstuff2001@…> 9 years ago.
EditGrid.trunk.2.patch (127.8 KB) - added by Bill Stuff <billstuff2001@…> 9 years ago.
Patch which *compiles* against trunk. Might not work. YMMV
thumbs_v1.patch (13.3 KB) - added by Jim Stichnoth 8 years ago.
Here is a prototype implementation of the concept that uses the existing edit screen.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by Bill Stuff <billstuff2001@…>

Attachment: bball.jpg added

Screenshot

Changed 9 years ago by Bill Stuff <billstuff2001@…>

Attachment: EditGrid.all.1.patch added

comment:1 Changed 9 years ago by J.Pilk@…

I liked the look of this when Bill first submitted his original version two years ago. It would be great to see it committed - and in fixes. This looks the most appropriate place to record that.

comment:2 Changed 9 years ago by markk

Bill

This is a big patch and I haven't had a chance to try and get it working with trunk, so please forgive me if I've missed something.

Can you clarify what additional features this adds? (over and above the obvious of providing the extra frames). Implementation details aside, this is a lot of code for what appears to be a small amount of fairly niche functionality - and something that adds additional overhead for a fully completed theme.

Implementation wise:-

  • I'd personally rather see this displayed and themed as part of the OSD. This seems the most logical place to handle it (we already have the current frame on screen), avoids the extra main UI integration (and the complications involved) and makes it a little more future proof (the implementation of guidedrid etc causes many problems and it needs changing).
  • I'm not sure I see the utility of displaying a series of frames that are, for example, 60seconds apart. frame by frame yes - but otherwise it's just confusing.
  • If you stick to the next and previous X frames, you by and large have these available already - or at least it would take relatively little work to ensure that you have a buffer of 11 frames, and re-position to the middle.

All told, I think I can see a far simpler solution that hence is more maintainable and, if done properly, requires minimal theming. Unless I've missed the point...

Changed 9 years ago by Bill Stuff <billstuff2001@…>

Attachment: EditGrid.trunk.2.patch added

Patch which *compiles* against trunk. Might not work. YMMV

comment:3 Changed 9 years ago by beirdo

Owner: set to sphery
Status: newassigned
Summary: Updated enhanced cutpoint edit functionality patch[PATCH] Updated enhanced cutpoint edit functionality patch

comment:4 Changed 8 years ago by Raymond Wagner

Version: UnspecifiedTrunk Head

Changed 8 years ago by Jim Stichnoth

Attachment: thumbs_v1.patch added

Here is a prototype implementation of the concept that uses the existing edit screen.

comment:5 Changed 8 years ago by Jim Stichnoth

Owner: changed from sphery to Jim Stichnoth
Status: assignedaccepted

Attachment thumbs_v1.patch implements this concept within the existing cutlist editor screen.

In osd.xml in the osd_program_editor window, you can define any number of <imagetype> objects whose name starts with "thumbnail_". The rest of the name is a floating point value that specifies where to grab a thumbnail image, in terms of the number of edit distance "steps" away from the current frame. Here is an example (based on a 1280x720 OSD theme size):

      <imagetype name="thumbnail_-2">
	<filename>images/background.png</filename>
	<area>200,0,200,200</area>
	<preserveaspect>true</preserveaspect>
	<alpha>200</alpha>
      </imagetype>
      <imagetype name="thumbnail_-1">
	<filename>images/background.png</filename>
	<area>400,0,200,200</area>
	<preserveaspect>true</preserveaspect>
	<alpha>200</alpha>
      </imagetype>
      <imagetype name="thumbnail_1">
	<filename>images/background.png</filename>
	<area>680,0,200,200</area>
	<preserveaspect>true</preserveaspect>
	<alpha>200</alpha>
      </imagetype>
      <imagetype name="thumbnail_2">
	<filename>images/background.png</filename>
	<area>880,0,200,200</area>
	<preserveaspect>true</preserveaspect>
	<alpha>200</alpha>
      </imagetype>
      <imagetype name="thumbnail_10">
	<filename>images/background.png</filename>
	<area>1105,200,175,175</area>
	<preserveaspect>true</preserveaspect>
	<alpha>200</alpha>
      </imagetype>
      <imagetype name="thumbnail_-10">
	<filename>images/background.png</filename>
	<area>0,200,175,175</area>
	<preserveaspect>true</preserveaspect>
	<alpha>200</alpha>
      </imagetype>

A background helper thread loads the thumbnails in the order specified. One to-do item is to dynamically change that order to prioritize for the frames the user likely wants to see first. Another item is to improve the design of the thumbnail choice/size/placement.

Note: See TracTickets for help on using tickets.