Opened 14 years ago

Closed 14 years ago

#962 closed patch (fixed)

SEGV: RemoteGetConflictList returns NULL but the caller expects empty vector

Reported by: bolek-mythtv@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In case there aren't any conflicts, RemoteGetConflictList? returns NULL. But the only call in ProgramInfo::ShowNotRecordingDialog? is expecting an empty vector instead. This is causing a SEGV in mythfrontend.

The attached patch against 8517 fixes the problem by always returning a non-null vector. The alternative would be to add a null check at the call site, but there is no benefit in doing this since the vector is allocated anyway (before it is known that it is empty).

Attachments (1)

noconflict-patch.txt (483 bytes) - added by bolek-mythtv@… 14 years ago.

Download all attachments as: .zip

Change History (2)

Changed 14 years ago by bolek-mythtv@…

Attachment: noconflict-patch.txt added

comment:1 Changed 14 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [8518]) Fix a bug in RemoteGetConflictList?(). This function is supposed to return a vector whether it is empty or not, but evidently I 'optimized' that out when I did a little cleanup in remoteutil.cpp a while back. Applies patch from and Closes #962.

Note: See TracTickets for help on using tickets.